Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aaa] Drop usage of RBAC v1beta1 #2436

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 30, 2021

RBAC is GA since kubernetes 1.8 :
https://kubernetes.io/blog/2017/10/using-rbac-generally-available-18/.

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. wg/k8s-infra labels Jul 30, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and spiffxp July 30, 2021 19:36
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2021
@ameukam ameukam removed request for spiffxp and nikhita July 30, 2021 19:36
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4564a75 into kubernetes:main Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 30, 2021
@spiffxp
Copy link
Member

spiffxp commented Aug 2, 2021

I neglected to do this when I approved last week. Hopefully nothing mysterious happens now.

$ ./ensure-namespaces.sh gke_kubernetes-public_us-central1_aaa
Create namespace: gcsweb
namespace/gcsweb unchanged
Apply namespace-user role: gcsweb
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: gcsweb
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: gcsweb is present
Create namespace: kettle
namespace/kettle unchanged
Apply namespace-user role: kettle
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: kettle
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: kettle is present
Create namespace: k8s-io-prod
namespace/k8s-io-prod unchanged
Apply namespace-user role: k8s-io-prod
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: k8s-io-prod
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: k8s-io-prod is present
Create namespace: k8s-io-canary
namespace/k8s-io-canary unchanged
Apply namespace-user role: k8s-io-canary
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: k8s-io-canary
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: k8s-io-canary is present
Create namespace: kubernetes-external-secrets
namespace/kubernetes-external-secrets unchanged
Apply namespace-user role: kubernetes-external-secrets
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: kubernetes-external-secrets
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: kubernetes-external-secrets is present
Create namespace: perfdash
namespace/perfdash unchanged
Apply namespace-user role: perfdash
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: perfdash
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: perfdash is present
Create namespace: prow
namespace/prow unchanged
Apply namespace-user role: prow
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: prow
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: prow is present
Create namespace: publishing-bot
namespace/publishing-bot unchanged
Apply namespace-user role: publishing-bot
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: publishing-bot
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: publishing-bot is present
Create namespace: sippy
namespace/sippy unchanged
Apply namespace-user role: sippy
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: sippy
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: sippy is present
Create namespace: slack-infra
namespace/slack-infra unchanged
Apply namespace-user role: slack-infra
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: slack-infra
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: slack-infra is present
Create namespace: triageparty-release
namespace/triageparty-release unchanged
Apply namespace-user role: triageparty-release
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: triageparty-release
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: triageparty-release is present
Create namespace: triageparty-scalability
namespace/triageparty-scalability unchanged
Apply namespace-user role: triageparty-scalability
role.rbac.authorization.k8s.io/namespace-user configured
Apply namespace-user role binding: triageparty-scalability
rolebinding.rbac.authorization.k8s.io/namespace-user configured
Ensure only one role binding in namespace: triageparty-scalability is present
Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants