Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to networking.k8s.io/v1 #2425

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Migrate to networking.k8s.io/v1 #2425

merged 3 commits into from
Jul 30, 2021

Conversation

jimdaga
Copy link

@jimdaga jimdaga commented Jul 30, 2021 •
edited
Loading

Resolves:

Changes:

  • Update all k8s-infra aaa ingress objects to networking.k8s.io/v1
  • Move backend configs to newer format

Notes

  • I ended up closing my first PR and staring over since there was a mess of merge conflicts. This one should be cleaner since I will not be sitting on it.
  • I was reading over Convert gcsweb to VPC native LB #2080 (comment) and Tim hinted there may be a "safer" way to migrate to NEGs. I think it would be safest to get this change done first, then we can move a few of the smaller risk apps over to NEGs as a starting point, then do everything else. I may test a few things out in my own clusters to get comfortable with the migration process first.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jimdaga. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra wg/reliability Categorizes an issue or PR as relevant to WG Reliability size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2021
@jimdaga jimdaga changed the title [WIP] Migrate to networking.k8s.io/v1 Migrate to networking.k8s.io/v1 Jul 30, 2021
@jimdaga jimdaga marked this pull request as ready for review July 30, 2021 03:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2021
@jimdaga jimdaga mentioned this pull request Jul 30, 2021
Closed
6 tasks
spiffxp
spiffxp approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 30, 2021
@spiffxp spiffxp mentioned this pull request Jul 30, 2021
Closed
@spiffxp
Copy link
Member

spiffxp commented Jul 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 30, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@jimdaga
Copy link
Author

jimdaga commented Jul 30, 2021

/retest

spiffxp
spiffxp approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimdaga, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit df8105a into kubernetes:main Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 30, 2021
@spiffxp spiffxp mentioned this pull request Jul 30, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Jul 30, 2021

Spot check of apps post-deploy, they're all working fine. Thanks @jimdaga !

@jimdaga jimdaga deleted the issue-2316/update-ingress branch July 30, 2021 14:46
@spiffxp spiffxp mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/reliability Categorizes an issue or PR as relevant to WG Reliability
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@jimdaga @k8s-ci-robot @spiffxp