Fix BigQuery Transfer config #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaud Meukam <[email protected]>
Official documentation about the resource `google_bigquery_data_transfer_config` is incorrect on some points. I added and fixed some fields and parameters blocks. Used source code of the resource and official GCP documentation: https://github.com/hashicorp/terraform-provider-google/blob/master/google/resource_bigquery_data_transfer_config.go https://cloud.google.com/bigquery/docs/copying-datasets#setting_up_a_dataset_copy Signed-off-by: Arnaud Meukam <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/terraform
|
Manually triggered the transfer and we got the same tables: bq ls k8s-infra-public-pii:k8s_infra_artifacts_gcslogs
tableId Type Labels Time Partitioning Clustered Fields
--------------------------------------------------------- ------- -------- ------------------- ------------------
1_etl_test_distinct_ip_org TABLE
2_etl_test_distinct_ip_and_int_org TABLE
3_etl_test_potaroo_with_yaml_names_org TABLE
4_etl_test_potaroo_with_yaml_names_in_one_column_org TABLE
5_etl_test_vendor_with_company_name_org TABLE
6_etl_test_join_asn_and_distinct_ip_org TABLE
7_asn_company_c_ip_lookup_anazon_only TABLE
7_etl_test_join_usage_all_with_asn_and_company_name_org TABLE
asn_client_ip_lookup TABLE
total_logs_per_ip_counted9_june_2021 TABLE
usage_and_asn_data TABLE
usage_and_asn_data_bq TABLE
usage_and_asn_data_bq_distinct TABLE
usage_and_asn_data_org TABLE |
|
job replication is successfully launched but failed to replicated: I'll open a followup PR for the permissions issue. This PR can be merged. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #2409.
Official documentation about the resource
google_bigquery_data_transfer_configis incorrect on some points. I added and fixed some fields and parameters blocks.Refs:
https://github.com/hashicorp/terraform-provider-google/blob/master/google/resource_bigquery_data_transfer_config.go
https://cloud.google.com/bigquery/docs/copying-datasets#setting_up_a_dataset_copy