Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra/gcp/main: update expected services #2405

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 28, 2021

Part of #1887

It appears gcloud services list no longer returns dependency info, so add some extra services I happen to know we depend on.

This PR is being accompanied by some manual service disables I'll comment on next

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra labels Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin July 28, 2021 20:08
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2021
@spiffxp spiffxp changed the title infra/gcp/main: update expected services [wip] infra/gcp/main: update expected services Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 28, 2021

Here's the state of things before this PR

  expected:
    - bigquery.googleapis.com
    - cloudasset.googleapis.com
    - container.googleapis.com
    - dns.googleapis.com
    - logging.googleapis.com
    - monitoring.googleapis.com
    - secretmanager.googleapis.com
    - storage-component.googleapis.com
  to_enable: []
  to_disable:
    - bigquerystorage.googleapis.com
    - clouderrorreporting.googleapis.com
    - cloudfunctions.googleapis.com
    - cloudresourcemanager.googleapis.com
    - cloudshell.googleapis.com
    - compute.googleapis.com
    - containerregistry.googleapis.com
    - iam.googleapis.com
    - iamcredentials.googleapis.com
    - oslogin.googleapis.com
    - pubsub.googleapis.com
    - serviceusage.googleapis.com
    - source.googleapis.com
    - stackdriver.googleapis.com
    - storage-api.googleapis.com

@spiffxp spiffxp force-pushed the update-main-expected-services branch from 0a5b9e9 to ce7e13a Compare July 28, 2021 20:24
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 28, 2021

Things I manually disabled:

  • cloudfunctions - we don't use this (or shouldn't be)
  • clouderrorreporting - this is used by the auditor, but that does run in kubernetes-public
  • source - is only around because cloudfunctions uses it

@spiffxp
Copy link
Member Author

spiffxp commented Jul 28, 2021

This is the output from ./infra/gcp/ensure-main-services.sh with this PR

  expected:
    - bigquery.googleapis.com
    - cloudasset.googleapis.com
    - cloudshell.googleapis.com
    - compute.googleapis.com
    - container.googleapis.com
    - containerregistry.googleapis.com
    - dns.googleapis.com
    - iam.googleapis.com
    - iamcredentials.googleapis.com
    - logging.googleapis.com
    - monitoring.googleapis.com
    - oslogin.googleapis.com
    - pubsub.googleapis.com
    - secretmanager.googleapis.com
    - storage-api.googleapis.com
    - storage-component.googleapis.com
  to_enable: []
  to_disable:
    - bigquerystorage.googleapis.com
    - cloudresourcemanager.googleapis.com
    - serviceusage.googleapis.com
    - stackdriver.googleapis.com

All of the remaining services have "usage" in the past 30 days according the serviceusage API. What that means exactly I don't have time to dig into

@spiffxp spiffxp changed the title [wip] infra/gcp/main: update expected services infra/gcp/main: update expected services Jul 28, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 28, 2021

/cc @ameukam @dims

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims July 28, 2021 20:31
@dims
Copy link
Member

dims commented Jul 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 776ea0b into kubernetes:main Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 28, 2021
@spiffxp spiffxp deleted the update-main-expected-services branch July 29, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants