Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS entries for k8s-infra-prow.k8s.io #2404

Merged
merged 2 commits into from
Jul 28, 2021
Merged

DNS entries for k8s-infra-prow.k8s.io #2404

merged 2 commits into from
Jul 28, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 28, 2021

Ref: #1394

This is required by #2235 to be able to create the Google SSL certificate for k8s-infra-prow.k8s.io.

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot requested review from spiffxp and thockin July 28, 2021 17:49
@k8s-ci-robot k8s-ci-robot added area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2021
@ameukam
Copy link
Member Author

ameukam commented Jul 28, 2021

Already ran terraform apply on f499b4f.

cc @dims @spiffxp

@ameukam ameukam force-pushed the k8s-infra-prow-dns branch from f62989c to fdf8ae6 Compare July 28, 2021 17:55
spiffxp
spiffxp approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2a91ff8 into kubernetes:main Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 28, 2021
@ameukam ameukam mentioned this pull request Jul 28, 2021
Merged
@ameukam ameukam mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @spiffxp