Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra/gcp: allow prow trusted cluster use of k8s-infra-ci-robot #2403

Merged
merged 1 commit into from
Jul 28, 2021
Merged

infra/gcp: allow prow trusted cluster use of k8s-infra-ci-robot #2403

merged 1 commit into from
Jul 28, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 28, 2021

Related:

This will allow jobs in k8s-infra-prow-build-trusted to use k8s-infra-ci-robot-github-token to be able to open up PRs as k8s-infra-ci-robot

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2021
@spiffxp spiffxp mentioned this pull request Jul 28, 2021
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Jul 28, 2021

Ran ./infra/gcp/ensure-main-project.sh

Ensuring prow special cases for: kubernetes-public
  Special case: ensuring k8s-infra-ci-robot-github-token accessible by k8s-infra-prow-build-trusted
  Updated IAM policy for secret [k8s-infra-ci-robot-github-token].
  @@ -1,2 +1,4 @@
   - member: group:[email protected]
     role: roles/secretmanager.admin
  +- member: serviceAccount:kubernetes-external-secrets@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
  +  role: roles/secretmanager.secretAccessor

@spiffxp
Copy link
Member Author

spiffxp commented Jul 28, 2021

/cc @ameukam @dims

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims July 28, 2021 17:15
@ameukam
Copy link
Member

ameukam commented Jul 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7ea4d2f into kubernetes:main Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 28, 2021
@spiffxp spiffxp deleted the use-k8s-infra-ci-robot-in-trusted branch July 28, 2021 17:26
This was referenced Jul 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-blackwelder e-blackwelder Awaiting requested review from e-blackwelder

@hasheddan hasheddan Awaiting requested review from hasheddan

@ameukam ameukam Awaiting requested review from ameukam

@dims dims Awaiting requested review from dims

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam