Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/perfdash: migrate ingress to v1 #2397

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 27, 2021

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mm4tt and wojtek-t July 27, 2021 23:28
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2021
@rikatz
Copy link
Contributor

rikatz commented Jul 27, 2021

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 92f0f31 into kubernetes:main Jul 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 27, 2021
@spiffxp spiffxp deleted the fix-perfdash-ingress branch July 27, 2021 23:36
@spiffxp
Copy link
Member Author

spiffxp commented Jul 27, 2021

Hooray, slack notifications for app deployments work! From https://kubernetes.slack.com/archives/CUD6HL48N/p1627428950009300
Screen Shot 2021-07-27 at 4 38 18 PM

@spiffxp
Copy link
Member Author

spiffxp commented Jul 27, 2021

(I was really using this to verify the results of kubernetes/test-infra#23040 landing)

@rikatz
Copy link
Contributor

rikatz commented Jul 28, 2021

Ooh this is cool!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants