Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra/gcp: mv k8s-releng-prod to its own folder #2349

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 15, 2021

k8s-releng-prod may be a release-related project, but it should not be handled by ensure-release-projects.sh

Move it to its own folder/group in infra.yaml to prevent #2322 (comment) from happening again

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin July 15, 2021 23:57
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

/cc @puerco @cpanato @justaugustus
FYI @kubernetes/release-engineering

@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

I've already re-run ./infra/gcp/ensure-releng.sh and ./infra/gcp/ensure-release-projects.sh to ensure no delta from the current, correct state

@puerco
Copy link
Member

puerco commented Jul 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit de67ed9 into kubernetes:main Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 16, 2021
@spiffxp spiffxp deleted the releng-prod-is-its-own-thing branch July 16, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants