Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request new group for sig-security-tooling #2342

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Jul 15, 2021

  • Added OWNERS file and groups.yaml file for a security tooling group that is used for private triage of vulnerabilities identified via automated scans
  • Removed a line in README, that does not reflect the current conventions tested

Related PRs: kubernetes/community#5853 and kubernetes/test-infra#22833

Relevant Slack threads:
Question
Answer 1
Answer 2

/cc @IanColdwater @tabbysable @justaugustus

- Added owners file and groups.yaml file for a
  private security tooling group that is used for
  private triage of vulnerabilities identified
  via automated scans
- Removed a line in README, that does not reflect
  the current conventions tested
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from spiffxp and thockin July 15, 2021 21:43
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2021
@PushkarJ
Copy link
Member Author

Used wrong command to request review earlier. Fixing now

/cc @IanColdwater @tabbysable @justaugustus

/sig security

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Jul 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PushkarJ, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@@ -3,7 +3,6 @@
## Making changes

- Edit `groups.yaml` to add a new group or update an existing group
- All groups MUST start with "k8s-infra-" prefix for the reconcile.go to work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants