Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: update READMEs, remove --dry-run from deploy.sh #2314

Merged
merged 3 commits into from
Jul 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ Kubernetes project infrastructure, managed by the kubernetes comunity via [wg-k8
- `apps`: community-managed apps that run on the community-managed `aaa` cluster
- `gcsweb`: instance of [gcsweb] at https://gcsweb.k8s.io - owned by [sig-testing]
- `kubernetes-external-secrets`: instance of [kubernetes-external-secrets] - owned by [sig-testing]
- `node-perf-dash`: instance of [node-perf-dash] - owned by [sig-node] (TODO(https://github.com/kubernetes/k8s.io/issues/2150) migrate to apps/)
- `node-perf-dash`: instance of [node-perf-dash] - owned by [sig-node]
- `sippy`: instance of [sippy] at https://sippy.k8s.io - owned by [sig-architecture] (on behalf of [wg-reliability])
- `slack-infra`: instance of [slack-infra] including https://slack.k8s.io - owned by [sig-contributor-experience]
- `triageparty-release`: instance of [triage-party] - owned by [sig-release]
- `audit`: scripts to export all relevant gcp resources, and the most recently-reviewed export
- `cert-manager`: instance of [cert-manager] for the `aaa` cluster - owned by ???
- `dns`: DNS for kubernetes.io and k8s.io
Expand All @@ -23,7 +24,6 @@ Kubernetes project infrastructure, managed by the kubernetes comunity via [wg-k8
- `prow`: work-in-pogress instance of [prow] - owned by [sig-testing] (TODO(https://github.com/kubernetes/k8s.io/issues/2150) migrate to apps/)
- `publishing-bot`: instance of [publishing-bot] - owned by [sig-release] (TODO(https://github.com/kubernetes/k8s.io/issues/2150) migrate to apps/)
- `registry.k8s.io`: work-in-progress to support cross-cloud mirroring/hosting of containers and binaries
- `triage-party/release-team`: instance of [triage-party] - owned by [sig-release] (TODO(https://github.com/kubernetes/k8s.io/issues/2150) migrate to apps/)

TODO: are these actively in use or should they be retired?
- `artifacts`
Expand Down Expand Up @@ -58,4 +58,4 @@ Please see https://git.k8s.io/community/wg-k8s-infra for more information
[sig-scalability]: https://git.k8s.io/community/sig-scalability
[sig-testing]: https://git.k8s.io/community/sig-testing
[wg-k8s-infra]: https://git.k8s.io/community/wg-k8s-infra
[wg-reliability]: https://git.k8s.io/community/wg-reliability
[wg-reliability]: https://git.k8s.io/community/wg-reliability
4 changes: 2 additions & 2 deletions apps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ actually fits the apps we run today.
- enforcement
- OWNER constraints enforcemed by humans
- no validation of yaml beyond yamllint
- `app:` convention enforcement by humands
- `app:` convention enforcement by humans
- `*.yaml` can be more than k8s resources
- consider a `resources/` subdir convention for all k8s resources
- allows for config files etc. at app root
Expand All @@ -40,4 +40,4 @@ actually fits the apps we run today.
- consider a custom label `k8s-infra-app:`; could do prefix but then need to decide on a DNS name
- is this a convention worth enforcing? perhaps namespace is enough

[running-in-community-clusters.md]: /running-in-community-clusters.md
[running-in-community-clusters.md]: /running-in-community-clusters.md
2 changes: 1 addition & 1 deletion apps/gcsweb/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ fi

# deploy kubernetes resources
pushd "${SCRIPT_ROOT}" >/dev/null
kubectl --context="${context}" --namespace="${namespace}" apply --dry-run=client -f .
kubectl --context="${context}" --namespace="${namespace}" apply -f .
2 changes: 1 addition & 1 deletion apps/kubernetes-external-secrets/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ fi

# deploy kubernetes resources
pushd "${SCRIPT_ROOT}" >/dev/null
kubectl --context="${context}" --namespace="${namespace}" apply --dry-run=client -f .
kubectl --context="${context}" --namespace="${namespace}" apply -f .
2 changes: 1 addition & 1 deletion apps/node-perf-dash/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ fi

# deploy kubernetes resources
pushd "${SCRIPT_ROOT}" >/dev/null
kubectl --context="${context}" --namespace="${namespace}" apply --dry-run=client -f .
kubectl --context="${context}" --namespace="${namespace}" apply -f .
2 changes: 1 addition & 1 deletion apps/sippy/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ fi

# deploy kubernetes resources
pushd "${SCRIPT_ROOT}" >/dev/null
kubectl --context="${context}" --namespace="${namespace}" apply --dry-run=client -f .
kubectl --context="${context}" --namespace="${namespace}" apply -f .
2 changes: 1 addition & 1 deletion apps/triageparty-release/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ fi

# deploy kubernetes resources
pushd "${SCRIPT_ROOT}" >/dev/null
kubectl --context="${context}" --namespace="${namespace}" apply --dry-run=client -f .
kubectl --context="${context}" --namespace="${namespace}" apply -f .