-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow: add k8s-infra-gci-robot-github-token ExternalSecret #2224
prow: add k8s-infra-gci-robot-github-token ExternalSecret #2224
Conversation
/cc @ameukam |
#2226 has been deployed (if not yet merged) and I trialed deployment of this to ensure it worked. So this is now ready for merge |
/approve /hold please feel free to remove hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
Part of umbrella issue to setup a k8s-infra-prow instance on aaa, ref: #1394
Part of umbrella issue to migrate everything to ExternalSecrets, ref: #2220
Depends on #2226 to upgrade aaa's kubernetes-external-secrets to v8.x so we can use the v1 API.