Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: add k8s-infra-gci-robot-github-token ExternalSecret #2224

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 15, 2021

Part of umbrella issue to setup a k8s-infra-prow instance on aaa, ref: #1394
Part of umbrella issue to migrate everything to ExternalSecrets, ref: #2220

Depends on #2226 to upgrade aaa's kubernetes-external-secrets to v8.x so we can use the v1 API.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin June 15, 2021 21:12
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 15, 2021

/cc @ameukam

@spiffxp
Copy link
Member Author

spiffxp commented Jun 16, 2021

#2226 has been deployed (if not yet merged) and I trialed deployment of this to ensure it worked. So this is now ready for merge

@spiffxp spiffxp changed the title [wip] prow: add k8s-infra-gci-robot-github-token ExternalSecret prow: add k8s-infra-gci-robot-github-token ExternalSecret Jun 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@dims
Copy link
Member

dims commented Jun 16, 2021

/approve
/lgtm

/hold please feel free to remove hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Jun 16, 2021

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Jun 16, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9204784 into kubernetes:main Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 16, 2021
@spiffxp spiffxp deleted the external-secrets-k8s-infra-ci-robot branch June 16, 2021 17:39
@spiffxp spiffxp mentioned this pull request Jun 16, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants