infra/gcp/k8s-infra-public-pii: fix post-deployment issue of 2031. #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/terraform
Fix of a typo in the service name Ensure bucket k8s-infra-artifacts-gsclogs is not deleted with Terraoform Remove non-working IAM binding Signed-off-by: Arnaud Meukam <[email protected]>
k8s-ci-robot
added
size/S
spiffxp
approved these changes
Jun 14, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ameukam
added a commit
to ameukam/k8s.io
that referenced
this pull request
Jun 21, 2021
k8s-infra-artifacts-gcs-logs Followup of kubernetes#2212. Fix bindings to grant `[email protected]` permission to create and store logs in the bucket Signed-off-by: Arnaud Meukam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of a typo in the service name
Ensure bucket k8s-infra-artifacts-gsclogs is not deleted with Terraoform
Remove non-working IAM binding
Signed-off-by: Arnaud Meukam [email protected]