Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: migrate buckets, organizations to new format #2103

Merged
merged 3 commits into from
May 27, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 26, 2021

This is part of a series of PRs:

This is an attempt at making the next audit job PR easier to review by getting migration to the new format and introduction of new resources out of the way. See #2102 for specific details of new resources/layout

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin May 26, 2021 21:36
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 26, 2021
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2021
@spiffxp
Copy link
Member Author

spiffxp commented May 26, 2021

/hold
ref: #2102 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2021
@spiffxp spiffxp force-pushed the audit-add-services-migrated branch 2 times, most recently from c036355 to dc11ebf Compare May 27, 2021 02:32
@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2021

/hold
This can merge once #2102 merges

@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2021

/hold cancel
Looking for merge of either #2102 then this, or just this

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2021
@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2021

mmm.. depends on whether the audit job is going to beat me to it or not

@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2021

/hold cancel
audit job is not currently running

@spiffxp spiffxp force-pushed the audit-add-services-migrated branch from dc11ebf to 03bd384 Compare May 27, 2021 20:10
@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2021

rebased ontop of main now that #2102 has merged

@dims
Copy link
Member

dims commented May 27, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe60eab into kubernetes:main May 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 27, 2021
@spiffxp spiffxp deleted the audit-add-services-migrated branch May 27, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants