audit: refactor for easier local development #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
wg/k8s-infra
approved
This was referenced May 25, 2021
mechanical refactor into functions: - remove_all_gcp_project_audit_files - audit_gcp_organization - audit_all_gcp_projects_with_parent_id - audit_gcp_project - audit_gcp_project_service - main ensure each function removes whichever folder it is about to populate, instead of deleting everything up front (to support targeted audits), except for audit_all_gcp_projects_with_parent_id, since it's populating a flat/non-hiearchical folder that may contain projects with other parent id's touch up logging for consistency
- pull in infra/gcp/lib.sh - use indent for logging instead of manual "###" headers - drop use of CLOUDSDK_CORE_PROJECT and prefer explicit `--project` flag - lowercase function-local vars
For faster local dev, `audit-gcp.sh k8s-infra-foo` will delete and re-export audit files just for the k8s-infra-foo project
This should allow for: - `bq` to actually work the first time it is used to dump bigquery resources - the `audit-gcp.sh` script to be invokved from anywhere
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
late /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. The tl;dr summary is:
./audit-gcp.sh k8s-infra-foo k8s-infra-barto regenerate audit files just for those projects/hold
Using this to verify #2099