Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups/sig-cluster-lifecycle: make kubeadm alerts group discoverable #2070

Merged

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented May 20, 2021

Make the group viewable / discoverable by non-members.

These settings were discussed on slack:
https://kubernetes.slack.com/archives/CCK68P2Q2/p1621524263005700

Make the group viewable / discoverable by non-members.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2021
@k8s-ci-robot k8s-ci-robot requested a review from justinsb May 20, 2021 16:52
@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label May 20, 2021
@k8s-ci-robot k8s-ci-robot requested a review from timothysc May 20, 2021 16:52
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2021
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5ef0f86 into kubernetes:main May 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants