Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra/gcp: fix audit.viewer role and remove stray bindings #2058

Merged
merged 4 commits into from
May 19, 2021
Merged

infra/gcp: fix audit.viewer role and remove stray bindings #2058

merged 4 commits into from
May 19, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 19, 2021

See commits for details.

I have already deployed up to 16506e0, but opted to hold on the last one for review.

This will fix the main part of #2055

spiffxp added 4 commits May 19, 2021 01:04
@spiffxp
infra/gcp/roles: refresh roles
0e2e6a9
@spiffxp
infra/gcp/roles: add to audit.viewer
268c44d 
Specifically secretmanager.viewer, which apparently
[email protected] is directly bound to on the
organization
@spiffxp
infra/gcp/org: remove secretmanager.viewer binding
16506e0 
auditors should be getting all of their permissions through the custom
org role audit.viewer
@spiffxp
infra/gcp/org: remove stray user bindings
186bde0 
These were originally intended to be removed by 4e5eeed but for some
reason that did not happen before the code to do was removed by
623bb00.

The organizationAdmin binding was manually added at some point, and is
redundant in the face of the custom org role organization.admin
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin May 19, 2021 05:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2021
@ameukam
Copy link
Member

ameukam commented May 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit a4df700 into kubernetes:main May 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 19, 2021
@spiffxp spiffxp mentioned this pull request May 19, 2021
Closed
@spiffxp spiffxp deleted the fix-audit-viewer-role branch May 19, 2021 15:51
@spiffxp
Copy link
Member Author

spiffxp commented May 19, 2021

Ran ./infra/gcp/ensure-organization.sh to deploy the final changes

@spiffxp spiffxp mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam