Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: update as of 2021-05-06 #2006

Merged
merged 1 commit into from
May 6, 2021
Merged

audit: update as of 2021-05-06 #2006

merged 1 commit into from
May 6, 2021

Conversation

cncf-ci
Copy link
Contributor

@cncf-ci cncf-ci commented May 6, 2021

Audit Updates wg-k8s-infra

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin May 6, 2021 00:58
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2021
spiffxp
spiffxp approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

audit/org_kubernetes.io/iam.json
Comment on lines +70 to +73
"members": [
"group:[email protected]"
],
"role": "roles/orgpolicy.policyAdmin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, part of #2010 being deployed (ebece4e)

audit/org_kubernetes.io/roles/audit.viewer.json
@@ -145,6 +145,100 @@
"binaryauthorization.policy.getIamPolicy",
"clientauthconfig.brands.list",
"clientauthconfig.clients.list",
"cloudasset.assets.analyzeIamPolicy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All permission changes here expected, part of #2010 being deployed (6d93372)

audit/projects/kubernetes-public/buckets/k8s-infra-clusters-terraform/iam.json
"group:[email protected]",
"user:[email protected]"
"group:[email protected]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, this was the cleanup I did in #2001 (comment)

audit/projects/kubernetes-public/iam.json
Comment on lines +150 to +153
"group:[email protected]",
"group:[email protected]",
"group:[email protected]",
"group:[email protected]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, this was #2005 being deployed

audit/org_kubernetes.io/roles/organization.admin.json
@@ -1,12 +1,22 @@
{
"description": "Access to administer all resources belonging to the organization",
"includedPermissions": [
"billing.accounts.create",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All permission changes here expected, part of #2010 being deployed (669e340)

@spiffxp
Copy link
Member

spiffxp commented May 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@spiffxp spiffxp mentioned this pull request May 6, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 0c280f7 into kubernetes:main May 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@nikhita nikhita Awaiting requested review from nikhita

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@cncf-ci @k8s-ci-robot @spiffxp