Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add cri-o staging project" #1888

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Revert "Add cri-o staging project" #1888

merged 1 commit into from
Apr 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 8, 2021 •
edited
Loading

ref: #1882

This reverts #1883

cri-o is not part of kubernetes, as such it should not be hosted by k8s-infra (ref: #1883 (comment))

We still need to document this policy, ref: #915 (comment)

@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label Apr 8, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2021
@spiffxp spiffxp mentioned this pull request Apr 8, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Apr 8, 2021

/uncc @haircommander
/cc @saschagrunert @thockin @ameukam @derekwaynecarr @dchen1107

@thockin
Copy link
Member

thockin commented Apr 8, 2021

/lgtm
/approve

Was any of this actuated?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1eef308 into kubernetes:main Apr 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 8, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Apr 8, 2021

@thockin

Was any of this actuated?

I got as far as creating the project before I realized, and Ctrl-C'ed out of the script. I manually deleted the project. I'll keep an eye open for the next audit PR to see if I missed anything

@spiffxp spiffxp deleted the revert-1883 branch April 8, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@ameukam ameukam Awaiting requested review from ameukam

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@thockin thockin Awaiting requested review from thockin

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @thockin @k8s-ci-robot