audit-followup: remove stale iam bindings for e2e projects #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extracts some generic iam functions out of lib.sh changes: - ensure_custom_org_role_from_file -> ensure_custom_iam_role_from_file, support "org" or "project:foo" scopes - add comment for custom_org_role_name - add ensure_project_role_binding - add ensure_removed_project_role_binding - add _ensure_removed_resource_role_binding the latter two are going to be used for audit reconciliation as we find stale bindings
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/prow
|
/area infra/auditing |
k8s-ci-robot
added
the
area/audit
spiffxp
commented
Feb 25, 2021
| @@ -22,7 +22,7 @@ set -o nounset | |||
| set -o pipefail | |||
|
|
|||
| SCRIPT_DIR=$(dirname "${BASH_SOURCE[0]}") | |||
| . "${SCRIPT_DIR}/lib.sh" | |||
| . "${SCRIPT_DIR}/../lib.sh" | |||
There was a problem hiding this comment.
fixes regression introduced in #1636
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Mar 3, 2021
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
|
Related to refactoring infra/gcp, ref: #516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address the following:
group:[email protected]should not haveroles/viewer(ref: audit followup: inconsistent role bindings for k8s-infra-prow-viewers on e2e projects #1661)Should partially address the following:
user:*should not haveroles/ownerfor projects (ref: Infra turnup: Whoever creates the project is listed as Owner #299)