partial-audit: prow-boskos-* batch (1/4) update as of 2021-02-24

[cncf-ci]

Audit Updates wg-k8s-infra

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hh]

/ok-to-test

[spiffxp]

/approve
/lgtm
Same comments as #1710 (review)

An additional comment on something I don't quite understand

[spiffxp]

I will admit, I am not used to seeing -asia and -eu buckets get created by kube-up. It supports it, but I'm not used to seeing it. Has something changed?

https://github.com/kubernetes/kubernetes/blob/703e2bd2ebae1cc7737c12344a9e6fb13a6019a9/cluster/gce/util.sh#L336

https://github.com/kubernetes/kubernetes/blob/703e2bd2ebae1cc7737c12344a9e6fb13a6019a9/cluster/gce/util.sh#L255-L281

Looks like RELEASE_REGION_FALLBACK needs to be true for this to happen

• it defaults to false in kube-up...
• nothing currently sets it to true... https://cs.k8s.io/?q=RELEASE_REGION_FALLBACK&i=nope&files=&excludeFiles=&repos=

[spiffxp]

nit: I think we should consider dumping bucket metadata as part of audit

$ gsutil ls -L -b gs://kubernetes-staging-485128143e-asia
gs://kubernetes-staging-485128143e-asia/ :
	Storage class:			STANDARD
	Location type:			multi-region
	Location constraint:		ASIA
	Versioning enabled:		None
	Logging configuration:		None
	Website configuration:		None
	CORS configuration: 		None
	Lifecycle configuration:	None
	Requester Pays enabled:		None
	Labels:				None
	Default KMS key:		None
	Time created:			Sun, 09 Aug 2020 17:57:04 GMT
	Time updated:			Sun, 09 Aug 2020 17:57:04 GMT
	Metageneration:			1
	Bucket Policy Only enabled:	False
# ... snip ...

So the "time created" tells me whatever this was, it happened long ago. Well past our log retention on prow.k8s.io, gs://kubernetes-jenkins, or k8s-infra-prow-build.

Maybe consider deleting these and revisiting if they start popping up again

[spiffxp]

No wait, I lied... still definitely in use.

$ gcloud logging read \
  --project=k8s-infra-e2e-boskos-001 \
  --freshness=7d \
  '
    logName="projects/k8s-infra-e2e-boskos-001/logs/cloudaudit.googleapis.com%2Factivity" 
    protoPayload.serviceName="storage.googleapis.com"
    protoPayload.resourceName=~"-asia|-eu"
  ' \
  --format="value(timestamp,protoPayload.methodName,protoPayload.resourceName)"
2021-02-23T08:25:21.531295917Z	storage.objects.update	projects/_/buckets/kubernetes-staging-485128143e-eu/objects/bootstrap-e2e-devel/kubernetes-manifests.tar.gz.sha512
2021-02-23T08:25:21.523849115Z	storage.objects.update	projects/_/buckets/kubernetes-staging-485128143e-eu/objects/bootstrap-e2e-devel/kubernetes-manifests.tar.gz
2021-02-23T08:25:13.015559872Z	storage.objects.update	projects/_/buckets/kubernetes-staging-485128143e-eu/objects/bootstrap-e2e-devel/kubernetes-server-linux-amd64.tar.gz.sha512
2021-02-23T08:25:12.924159228Z	storage.objects.update	projects/_/buckets/kubernetes-staging-485128143e-eu/objects/bootstrap-e2e-devel/kubernetes-server-linux-amd64.tar.gz
2021-02-22T09:07:12.735014165Z	storage.objects.update	projects/_/buckets/kubernetes-staging-485128143e-asia/objects/bootstrap-e2e-devel/kubernetes-manifests.tar.gz.sha512
2021-02-22T09:07:12.657397014Z	storage.objects.update	projects/_/buckets/kubernetes-staging-485128143e-asia/objects/bootstrap-e2e-devel/kubernetes-manifests.tar.gz
# ...

It has to do with where the cluster is created.

spiffxp@spiffxp-macbookpro:test-infra (master)$ ag '(asia|europe)-'
config/jobs/kubernetes/sig-network/sig-network-misc.yaml
335:      - --gcp-zone=asia-southeast1-a
372:      - --gcp-zone=asia-southeast1-a

config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml
158:      - --gcp-zone=asia-southeast1-a
189:      - --gcp-zone=asia-southeast1-a

config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
849:      - --gcp-zone=europe-west1-c

config/jobs/kubernetes/sig-node/containerd.yaml
600:      - --gcp-zone=asia-southeast1-a

OK! carry on then

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hh]

/check-cla