Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Update for k8s-infra-boskos 64/160 #1652

Closed
wants to merge 1 commit into from

Conversation

hh
Copy link
Member

@hh hh commented Feb 16, 2021

There are a 160 boskos projects... so I'm going to do them in batches... likely in 3 sets.

It's already just over 1000+ files changed. I'll stop here for feedback before processing any more.

IF we want to go smaller batch, I can try and break them up. It's pretty much a manual run with a limit on the projects it iterates over, then cleaning up deletions for a PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp February 16, 2021 02:57
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hh
To complete the pull request process, please assign bartsmykla after the PR has been reviewed.
You can assign the PR to them by writing /assign @bartsmykla in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 16, 2021

/hold
I'd like to first merge the initial audit PR I opened since it has much more granular comments #1534 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

@hh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hh
Copy link
Member Author

hh commented Feb 18, 2021

Since we've merged all current changes, let's leave this until a normal PR submission from @cncf-ci

@hh hh closed this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants