Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new group for conformance Inspur #1426

Conversation

ydcool
Copy link
Contributor

@ydcool ydcool commented Nov 14, 2020

This PR requests a group for Inspur as well as a GCS bucket.

The bucket used to store cloud provider conformance test results of cloud-provider-inspur and it'll report to TestGrid according to Contributing Test Results.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin November 14, 2020 08:45
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. wg/k8s-infra labels Nov 14, 2020
@ydcool ydcool force-pushed the request_bucket_for_cloud_provider_inspur branch from 833bf7a to 1a6891e Compare November 14, 2020 08:47
@dims
Copy link
Member

dims commented Nov 20, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ydcool

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1885d14 into kubernetes:master Nov 20, 2020
@ydcool ydcool deleted the request_bucket_for_cloud_provider_inspur branch November 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants