Add an n1_highmem_8 nodepool to k8s-infra-prow-build to prep for migration #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Will track migration under #1173 |
spiffxp
commented
Aug 24, 2020
| # use an UBUNTU image instead. Keep parity with the existing google.com | ||
| # k8s-prow-builds/prow cluster by using the CONTAINERD variant | ||
| image_type = "UBUNTU_CONTAINERD" | ||
| machine_type = "n1-highmem-16" |
There was a problem hiding this comment.
Welp. Looks like this is gonna need a redo
Merged
spiffxp
added
the
area/prow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a suspicion that switching to n1-highmem-16 nodes has caused more jobs-per-node to be scheduled, thus leading to more contention over resources that aren't accounted for by the scheduler (such as IOPS)
This PR is the first step in undoing that change, by moving us back to n1-highmem-8's.
I am concerned that moving back to more, smaller nodes will cause us to hit our quota of IP's, and we'll have to shift jobs off of this cluster until we can find some other way to mitigate (ref: #1132 (comment))