Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo labels (area/) for different components #508

Closed
munnerz opened this issue Dec 11, 2019 · 24 comments
Closed

Add repo labels (area/) for different components #508

munnerz opened this issue Dec 11, 2019 · 24 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@munnerz
Copy link
Member

munnerz commented Dec 11, 2019

It was suggested that we use labels to denote issues by their area - Prow supports area/ labels for this, and there already exists one label that can be used as an example (area/dns): https://github.com/kubernetes/test-infra/blob/6baeb3d9949b9e6d9404dd3b4a6b28392de68ee0/label_sync/labels.yaml#L803-L810

These can then be set by commenting, for example: /area dns.

We should collate a list of labels here for the initial PR, and in future we can PR more directly into the labelsync config. A few to start:

  • area/velodrome
  • area/cert-manager
  • area/gcsweb
  • area/publishing-bot
  • area/boskos

A few more general ones that may be useful:

  • area/monitoring
  • area/reliability

We should write up descriptions for some of these bits too.

@rikatz
Copy link
Contributor

rikatz commented Dec 11, 2019

Based in #437:

  • area/aaa (or area/cluster)
  • area/auditing
  • area/site

Will think in some other areas :)

@justaugustus
Copy link
Member

It may useful to further scope the labels e.g., area/infra/**

ameukam added a commit to ameukam/test-infra that referenced this issue Jan 17, 2020
Requested kubernetes/k8s.io#508.
Add more labels that will help backlog triage
ameukam added a commit to ameukam/test-infra that referenced this issue Jan 21, 2020
Requested kubernetes/k8s.io#508.
Add more labels that will help backlog triage
ameukam added a commit to ameukam/test-infra that referenced this issue Feb 3, 2020
Requested kubernetes/k8s.io#508.
Add more labels that will help backlog triage
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 9, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 15, 2020

/remove-lifecycle rotten

Here's what we have:

  • area/access
  • area/artifacts
  • area/billing
  • area/cluster-infra
  • area/cluster-mgmt
  • area/dns
  • area/infra/auditing
  • area/infra/cert-manager
  • area/infra/monitoring
  • area/infra/publishing-bot
  • area/infra/reliability

Synced via: https://github.com/kubernetes/test-infra/blob/c9d7d82dca1c4966db01d732ea942022da838ac2/label_sync/labels.yaml#L831-L897

I don't particularly enjoy this list, because some of it is cross-cutting concerns, and some of it corresponds to specific directories. Some of it uses infra/ some of it does not.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 15, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Jan 23, 2021

/remove-lifecycle rotten
/milestone v1.21
I can take another crack at this, or I'm open to suggestions from others

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 23, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 8, 2021

/reopen
and I forgot to reopen...

@k8s-ci-robot k8s-ci-robot reopened this Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/reopen
and I forgot to reopen...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Feb 8, 2021

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 8, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 22, 2021

/remove-priority backlog
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 22, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 22, 2021

Mentioned this during last weeks meeting. I feel like this is a proxy for how we think about, model and organize our work. We've got debt to pay down to make it easier to manage and onboard. So it's more important than "eh they're just labels"

I feel like we should have one set for currently running apps or services. Things like dns, k8s.gcr.io for services. Things like triage-party, slack-infra, publishing-bot for apps (things running in aaa).

There are cross-cutting apps/services that span infra and folders (eg prow, staging repos)

There are also cross-cutting concerns like authentication, authorization, auditability, observability etc

An alternative approach used by test-infra is to map area labels to folder structure. This would require shuffling of code to get to desired labelset. Or we could start by making labels that align to folders we have today

@ameukam
Copy link
Member

ameukam commented Apr 22, 2021

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.21 milestone Apr 22, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2021
@ameukam
Copy link
Member

ameukam commented Jul 21, 2021

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 21, 2021
@spiffxp
Copy link
Member

spiffxp commented Jul 22, 2021

Here's what we have:

  • area/access
  • area/artifacts
  • area/billing
  • area/cluster-infra
  • area/cluster-mgmt
  • area/dns
  • area/infra/auditing
  • area/infra/cert-manager
  • area/infra/monitoring
  • area/infra/publishing-bot
  • area/infra/reliability
  • area/infra/terraform
  • area/prow
  • area/release-eng

Here's what I propose:

  • drop area/infra/reliability, area/infra/monitoring, area/access
  • keep releng labels area/artifacts, area/release-eng
  • add area/apps for issues related to apps in general, migrate area/cluster-infra
  • add area/apps/{foo} for apps/{foo} (migrate area/infra/publishing-bot, area/infra/cert-manager)
  • add area/infra for infra/gcp/* (and issues related to infra in general, migrate area/cluster-mgmt)
  • add area/terraform for infra/gcp/clusters/* (and issues/PRs related to terraform in general, migrate area/infra/terraform)
  • add area/bash for infra/gcp/clusters/*.sh (and issues/PRs related to "the bash scripts" in general)
  • add area/k8s.gcr.io for k8s.gcr.io/*
  • add area/audit for audit/* (and issues related to auditing)
  • add area/policy for policies/* (and issues related to policy formation/decisions, like what should (not) be allowed)
  • if I didn't mention it, keep it

Leaving us with:

  • area/apps
  • area/apps/cert-manager
  • area/apps/gcsweb
  • area/apps/k8s-io
  • area/apps/kubernetes-external-secrets
  • area/apps/node-perf-dash
  • area/apps/perfdash
  • area/apps/prow
  • area/apps/publishing-bot
  • area/apps/sippy
  • area/apps/slack-infra
  • area/apps/triageparty-release
  • area/artifacts
  • area/audit
  • area/bash
  • area/billing
  • area/dns
  • area/infra
  • area/k8s.gcr.io
  • area/policy
  • area/prow
  • area/release-eng
  • area/terraform

Or in patch form:

@@ -1,14 +1,23 @@
-- area/access
+- area/apps
+- area/apps/cert-manager
+- area/apps/gcsweb
+- area/apps/k8s-io
+- area/apps/kubernetes-external-secrets
+- area/apps/node-perf-dash
+- area/apps/perfdash
+- area/apps/prow
+- area/apps/publishing-bot
+- area/apps/sippy
+- area/apps/slack-infra
+- area/apps/triageparty-release
 - area/artifacts
+- area/audit
+- area/bash
 - area/billing
-- area/cluster-infra
-- area/cluster-mgmt
 - area/dns
-- area/infra/auditing
-- area/infra/cert-manager
-- area/infra/monitoring
-- area/infra/publishing-bot
-- area/infra/reliability
-- area/infra/terraform
+- area/infra
+- area/k8s.gcr.io
+- area/policy
 - area/prow
 - area/release-eng
+- area/terraform

@spiffxp
Copy link
Member

spiffxp commented Jul 22, 2021

Why both area/apps/prow and area/prow?

One is about the specific app or set of resources deployed on aaa

The other is about all prow concerns in general, include the build clusters, migrating prow jobs, etc

Why drop everything out of area/infra/foo?

Conceptually, area/apps/foo maps directly to the files/app in apps/foo. The same can't be said for the area/infra/foo. We could move high-level "infra" or "services" into infra, but since dns/ and especially k8s.gcr.io/ get so much traffic where they are, I'd rather not relocate until we know for sure where they're going. And how to organize our infra config / scripts beyond "put them all in infra" is not obvious to me right now.

I considered area/infra/gcp, but we can use area/provider/gcp and other area/provider/foo labels if we need to talk about other cloud providers (and if we find that ends up conflating things, we'll migrate then...)

@spiffxp
Copy link
Member

spiffxp commented Jul 30, 2021

I've opened kubernetes/test-infra#23084 to implement the above

@spiffxp
Copy link
Member

spiffxp commented Aug 3, 2021

/assign

@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2021

/close

Calling this done, now that the following have merged:

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close

Calling this done, now that the following have merged:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

7 participants