-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repo labels (area/) for different components #508
Comments
Based in #437:
Will think in some other areas :) |
It may useful to further scope the labels e.g., |
Requested kubernetes/k8s.io#508. Add more labels that will help backlog triage
Requested kubernetes/k8s.io#508. Add more labels that will help backlog triage
Requested kubernetes/k8s.io#508. Add more labels that will help backlog triage
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten Here's what we have:
I don't particularly enjoy this list, because some of it is cross-cutting concerns, and some of it corresponds to specific directories. Some of it uses infra/ some of it does not. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
/reopen |
@spiffxp: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority backlog |
/remove-priority backlog |
Mentioned this during last weeks meeting. I feel like this is a proxy for how we think about, model and organize our work. We've got debt to pay down to make it easier to manage and onboard. So it's more important than "eh they're just labels" I feel like we should have one set for currently running apps or services. Things like dns, k8s.gcr.io for services. Things like triage-party, slack-infra, publishing-bot for apps (things running in aaa). There are cross-cutting apps/services that span infra and folders (eg prow, staging repos) There are also cross-cutting concerns like authentication, authorization, auditability, observability etc An alternative approach used by test-infra is to map area labels to folder structure. This would require shuffling of code to get to desired labelset. Or we could start by making labels that align to folders we have today |
/milestone clear |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Here's what we have:
Here's what I propose:
Leaving us with:
Or in patch form: @@ -1,14 +1,23 @@
-- area/access
+- area/apps
+- area/apps/cert-manager
+- area/apps/gcsweb
+- area/apps/k8s-io
+- area/apps/kubernetes-external-secrets
+- area/apps/node-perf-dash
+- area/apps/perfdash
+- area/apps/prow
+- area/apps/publishing-bot
+- area/apps/sippy
+- area/apps/slack-infra
+- area/apps/triageparty-release
- area/artifacts
+- area/audit
+- area/bash
- area/billing
-- area/cluster-infra
-- area/cluster-mgmt
- area/dns
-- area/infra/auditing
-- area/infra/cert-manager
-- area/infra/monitoring
-- area/infra/publishing-bot
-- area/infra/reliability
-- area/infra/terraform
+- area/infra
+- area/k8s.gcr.io
+- area/policy
- area/prow
- area/release-eng
+- area/terraform |
Why both One is about the specific app or set of resources deployed on aaa The other is about all prow concerns in general, include the build clusters, migrating prow jobs, etc Why drop everything out of Conceptually, I considered |
I've opened kubernetes/test-infra#23084 to implement the above |
/assign |
/close Calling this done, now that the following have merged:
|
@spiffxp: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It was suggested that we use labels to denote issues by their area - Prow supports
area/
labels for this, and there already exists one label that can be used as an example (area/dns
): https://github.com/kubernetes/test-infra/blob/6baeb3d9949b9e6d9404dd3b4a6b28392de68ee0/label_sync/labels.yaml#L803-L810These can then be set by commenting, for example:
/area dns
.We should collate a list of labels here for the initial PR, and in future we can PR more directly into the labelsync config. A few to start:
area/velodrome
area/cert-manager
area/gcsweb
area/publishing-bot
area/boskos
A few more general ones that may be useful:
area/monitoring
area/reliability
We should write up descriptions for some of these bits too.
The text was updated successfully, but these errors were encountered: