Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create S3 buckets in AWS regions #3595

Closed
3 tasks done
Tracked by #3568
jaypipes opened this issue Apr 4, 2022 · 26 comments
Closed
3 tasks done
Tracked by #3568

Create S3 buckets in AWS regions #3595

jaypipes opened this issue Apr 4, 2022 · 26 comments
Assignees
Labels
area/infra Infrastructure management, infrastructure design, code in infra/ area/release-eng Issues or PRs related to the Release Engineering subproject priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Milestone

Comments

@jaypipes
Copy link
Contributor

jaypipes commented Apr 4, 2022

  • Naming convention for buckets will be ${prefix}registry-k8s-io-${gcs_bucket_name}-${region}
  • Create buckets in each AWS region listed here via Terraform
  • Ted Z to vet the IAM role that will have permission to create buckets and write objects
@jaypipes jaypipes changed the title make bucket names globally unique or similar Create S3 buckets in AWS regions Apr 4, 2022
@riaankleinhans
Copy link
Contributor

/assign @jaypipes @BobyMCbobs

@hh
Copy link
Member

hh commented Apr 6, 2022

Maybe put the code within k/k8s.io infra/aws/registry.k8s.io/buckets for now.

@riaankleinhans
Copy link
Contributor

riaankleinhans commented Apr 6, 2022

From the data these are the regions:

us-west-2
eu-west-1
us-east-1
eu-central-1
us-east-2
ap-southeast-1
us-west-1
ap-northeast-1
ap-south-1

@riaankleinhans
Copy link
Contributor

The PR address the teraform of S3 buckets.
#3605

@riaankleinhans riaankleinhans moved this from Breakdown TODO to Implementation TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh hh moved this from Implementation TODO to Validation TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh hh moved this from Validation TODO to Implementation TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh hh moved this from Implementation TODO to Breakdown TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh hh moved this from Breakdown TODO to Implementation TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh hh moved this from Implementation TODO to Validation TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh
Copy link
Member

hh commented Apr 13, 2022

@BobyMCbobs we need a project to run this in. To create the buckets
Breakdown

@hh hh moved this from Validation TODO to Breakdown TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh
Copy link
Member

hh commented Apr 13, 2022

@jaypipes working with Adolfo to run the mirroring.
Jay has what he needs. Unblocked currently.

@arnaud >

We should do a one sync copy from GCS to S3... 10 buckets is going to take a while.

If we do the one sync, then later use the mirror to push these options. It's going to be easier, as we already have a copy of the source of truth over s3 so we don't waste time.
@dims >

We already have one is a single s3 bucket, we just need to copy to one.
We need to create one bucket and copy to the s3 bucket.

@arnaud > There is one permission to be added to do the once off sync

IAM role that image promoter will be using when doing the mirroring between GCS and S3

When we have that first bucket, then we can try some additional stuff that @BenTheElder is writing.

So we can redirect everything to that one bucket.... some prow jobs running inside AWS so we can test that.

  • IAMs roles for pushing is correct
  • IAM permissions for pushing to buckets to correct
  • The IAM role that's pushing that IAM needs IAM creation permissions
  • Run terrafrom!

Not technically a blocker... between Caleb and Arnaud.

@hh hh moved this from Breakdown TODO to Implementation TODO in registry.k8s.io (SIG K8S Infra) Apr 13, 2022
@hh
Copy link
Member

hh commented Apr 13, 2022

Arnaud is going to create another issue, lets be sure it's on the board.

@ameukam
Copy link
Member

ameukam commented Apr 21, 2022

Arnaud is going to create another issue, lets be sure it's on the board.

@hh From https://kubernetes.slack.com/archives/CCK68P2Q2/p1650407982934869, I'm now not sure if we need to created a new issue.

@BobyMCbobs
Copy link
Member

Update for things

@jaypipes and I have been paring on setting up the accounts in a organized manner and are setting up a new account for the registry buckets to go into.

The structure is root/Kubernetes (OU)/registry.k8s.io (OU)/[email protected] (account).

Currently in the middle of sorting IAM access to this account for provisioning the buckets and IAM role for accessing it.

Ticket for updating docs which reflect the org/account structuring: #3668

@ameukam
Copy link
Member

ameukam commented Apr 27, 2022

From meeting April 27,
Excepting production buckets by end of the week. If not create S3 buckets in the sandbox account.

@BobyMCbobs
Copy link
Member

Bucket update

Tried to do an initial password (re)set for the [email protected] AWS account.
@dims has been monitoring the emails from that address and no email has come through.

Will be paring with @jaypipes when next available to complete it.

@riaankleinhans
Copy link
Contributor

Buckets created in #3693

@riaankleinhans
Copy link
Contributor

add in eu-west-1 AWS region #3699

@ameukam
Copy link
Member

ameukam commented Jun 8, 2022

@BobyMCbobs @jaypipes Can we get the full list of the buckets names and the ARNs of those buckets ?

@BobyMCbobs
Copy link
Member

BobyMCbobs commented Jun 10, 2022

@BobyMCbobs @jaypipes Can we get the full list of the buckets names and the ARNs of those buckets ?

@ameukam, the bucket names and ARNs are as follows

  • arn:aws:s3:us-west-1:REDACTED:prod-registry-k8s-io-us-west-1
  • arn:aws:s3:us-west-2:REDACTED:prod-registry-k8s-io-us-west-2
  • arn:aws:s3:us-east-1:REDACTED:prod-registry-k8s-io-us-east-1
  • arn:aws:s3:us-east-2:REDACTED:prod-registry-k8s-io-us-east-2
  • arn:aws:s3:eu-central-1:REDACTED:prod-registry-k8s-io-eu-central-1
  • arn:aws:s3:ap-southeast-1:REDACTED:prod-registry-k8s-io-ap-southeast-1
  • arn:aws:s3:ap-northeast-1:REDACTED:prod-registry-k8s-io-ap-northeast-1
  • arn:aws:s3:ap-south-1:REDACTED:prod-registry-k8s-io-ap-south-1

(this is me figuring out the ARNs so let me know if it works OK)

cc @Riaankl

@ameukam
Copy link
Member

ameukam commented Jun 15, 2022

@BobyMCbobs Thanks!!! I took the liberty edit the AWS accounts to avoid potential attacks.

@jaypipes
Copy link
Contributor Author

@BobyMCbobs Thanks!!! I took the liberty edit the AWS accounts to avoid potential attacks.

I don't think there's anything particularly sensitive about the AWS account ID, @ameukam :)

@ameukam
Copy link
Member

ameukam commented Jun 22, 2022

I think we can consider this as done.

@BobyMCbobs Now the buckets are up, what are the blockers to sync from the blobs from k8s.gcr.io to all those buckets ? (see: #3623)

@thockin
Copy link
Member

thockin commented Jun 24, 2022

Hey all, If this is done - who has access to these buckets and how do we govern that? We really really need to move this forward ASAP.

What's blocking?

@BenTheElder
Copy link
Member

BenTheElder commented Jun 24, 2022

xref: #3807 for a possible option to allow CI jobs to access AWS without storing creds once bootstrapped via workload identity.

Alternatively, if someone who has access currently can at least do a one-off sync #3623 of the current contents, we can at least make progress on rolling out "traffic to AWS" in registry.k8s.io while we finish figuring out the ongoing automated sync.

#3666 "bulk sync existing image layers to these s3 layers as a starting point (from GCS/GCR)"

@ameukam can provide pointers on rclone from GCR's GCS to s3.

@riaankleinhans
Copy link
Contributor

Hey all, If this is done - who has access to these buckets and how do we govern that? We really really need to move this forward ASAP.

What's blocking?

/cc @jaypipes

@BobyMCbobs
Copy link
Member

Depends on cncf-infra/aws-infra#4

@ameukam
Copy link
Member

ameukam commented Jul 5, 2022

/sig k8s-infra
/area infra
/area release-eng
/priority critical-urgent
/milestone v1.25
/close

Follow-up:

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. area/infra Infrastructure management, infrastructure design, code in infra/ labels Jul 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 5, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 5, 2022
@ameukam ameukam moved this from Implementation TODO to Validation Done in registry.k8s.io (SIG K8S Infra) Jul 5, 2022
@k8s-ci-robot
Copy link
Contributor

@ameukam: Closing this issue.

In response to this:

/sig k8s-infra
/area infra
/area release-eng
/priority critical-urgent
/milestone v1.25
/close

Follow-up:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from Validation Done to Breakdown Done in registry.k8s.io (SIG K8S Infra) Jul 5, 2022
@thockin
Copy link
Member

thockin commented Jul 5, 2022 via email

@riaankleinhans riaankleinhans moved this from Breakdown Done to Implementation TODO in registry.k8s.io (SIG K8S Infra) Jul 5, 2022
@ameukam
Copy link
Member

ameukam commented Jul 5, 2022

The purpose of the issue was to make sure the buckets exist whether private or public. anonymous access to those is a different goal and I think we should direct future questions to cncf-infra/aws-infra#4 (currently admins access to those buckets is handled by CNCF).

@riaankleinhans riaankleinhans moved this from Implementation TODO to Validation TODO in registry.k8s.io (SIG K8S Infra) Jul 18, 2022
@riaankleinhans riaankleinhans moved this from Validation TODO to Validation Done in registry.k8s.io (SIG K8S Infra) Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Infrastructure management, infrastructure design, code in infra/ area/release-eng Issues or PRs related to the Release Engineering subproject priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
Development

No branches or pull requests

8 participants