Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from google.com gcp project kubernetes-e2e-test-images #1522

Closed
2 tasks done
spiffxp opened this issue Jan 13, 2021 · 15 comments
Closed
2 tasks done

Migrate away from google.com gcp project kubernetes-e2e-test-images #1522

spiffxp opened this issue Jan 13, 2021 · 15 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented Jan 13, 2021

Related:

We should migrate away from the google.com-owned gcr.io/kubernetes-e2e-test-images and instead use the community-owned k8s.gcr.io/e2e-test-images repository.

Once we have done so, we should:

/wg k8s-infra
/sig testing
/sig release
/area release-eng

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jan 21, 2021

/assign @claudiubelu @aojea
who have done a fair amount of work on this already
/assign @spiffxp
/milestone v1.21

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2021
@ameukam
Copy link
Member

ameukam commented Apr 22, 2021

/remove-lifecycle stale
/milestone clear

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot removed this from the v1.21 milestone Apr 22, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Apr 23, 2021

/milestone v1.22
I believe we are close on this

@ameukam ameukam added this to the v1.23 milestone Jul 23, 2021
@ameukam ameukam removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 2, 2021

Current status:

@spiffxp
Copy link
Member Author

spiffxp commented Sep 17, 2021

There also remain a number of references to gcr.io/kubernetes-e2e-test-images through the project: https://cs.k8s.io/?q=gcr.io%2Fkubernetes-e2e-test-images&i=nope&files=&excludeFiles=vendor%2F&repos=

@spiffxp
Copy link
Member Author

spiffxp commented Sep 20, 2021

Repos that may need references updated in checklist form:

curl -s -X POST \
  -F "q=gcr.io/kubernetes-e2e-test-images" \
  -F "repos=*" \
  -F "excludeFiles=vendor/" \
  "https://cs.k8s.io/api/v1/search" \
| jq -r '.Results | keys | .[]' \
| sort \
| sed -e 's/^/- [ ] /g'

EDIT: updated as of 2021-11-03

@claudiubelu
Copy link
Contributor

I can take a look at them.

@claudiubelu
Copy link
Contributor

For lwkd, release-notes, and sig-release, it's noop. They only contain the release note regarding this migration:

./lwkd/_posts/2021-08-15-update.md:* [`k8s.gcr.io/e2e-test-images`](https://github.com/kubernetes/kubernetes/pull/103796) is the new `gcr.io/kubernetes-e2e-test-images`
./release-notes/src/assets/release-notes-1.23.0-alpha.1.json:    "markdown": "The image `gcr.io/kubernetes-e2e-test-images` will no longer be used in E2E / CI testing, `k8s.gcr.io/e2e-test-images` will be used instead. ([#103724](https://github.com/kubernetes/kubernetes/pull/103724), [@claudiubelu](https://github.com/claudiubelu))",
./release-notes/src/assets/release-notes-1.23.0-alpha.1.json:    "text": "The image `gcr.io/kubernetes-e2e-test-images` will no longer be used in E2E / CI testing, `k8s.gcr.io/e2e-test-images` will be used instead.",
./sig-release/releases/release-1.23/release-notes/maps/pr-103724-map.yaml:  text: The image `gcr.io/kubernetes-e2e-test-images` will no longer be used in E2E
./sig-release/releases/release-1.23/release-notes/release-notes-draft.json:    "markdown": "The image `gcr.io/kubernetes-e2e-test-images` will no longer be used in E2E / CI testing, `k8s.gcr.io/e2e-test-images` will be used instead. ([#103724](https://github.com/kubernetes/kubernetes/pull/103724), [@claudiubelu](https://github.com/claudiubelu))",
./sig-release/releases/release-1.23/release-notes/release-notes-draft.json:    "text": "The image `gcr.io/kubernetes-e2e-test-images` will no longer be used in E2E / CI testing, `k8s.gcr.io/e2e-test-images` will be used instead.",
./sig-release/releases/release-1.23/release-notes/release-notes-draft.md:- The image `gcr.io/kubernetes-e2e-test-images` will no longer be used in E2E / CI testing, `k8s.gcr.io/e2e-test-images` will be used instead. ([#103724](https://github.com/kubernetes/kubernetes/pull/103724), [@claudiubelu](https://github.com/claudiubelu))

@spiffxp
Copy link
Member Author

spiffxp commented Nov 3, 2021

kubernetes/website is the last remaining non-historical reference. There are some example and blog posts referencing the old repo. The problem is that the new repo doesn't have identical / equivalent images. I'm going to look at using gcrane or something to sync some more containers over to k8s-staging-e2e-test-images and promote accordingly.

@spiffxp
Copy link
Member Author

spiffxp commented Nov 3, 2021

Perhaps better to just update the examples...

@spiffxp
Copy link
Member Author

spiffxp commented Nov 24, 2021

Opened a followup issue to decommission the project post-deprecation: #3112

Will draft an announcement after test freeze

@spiffxp
Copy link
Member Author

spiffxp commented Nov 24, 2021

/close

Deprecation announced: https://groups.google.com/g/kubernetes-dev/c/jIrBjnw3cDg

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close

Deprecation announced: https://groups.google.com/g/kubernetes-dev/c/jIrBjnw3cDg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

6 participants