Skip to content

Commit

Permalink
Merge pull request #902 from dims/typo-fix-in-arguments
Browse files Browse the repository at this point in the history
typo - need to check if argument is zero or not
  • Loading branch information
k8s-ci-robot authored May 27, 2020
2 parents d0152ef + cb0e4d8 commit 935c758
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions infra/gcp/lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ function empower_artifact_auditor_invoker() {
# $2: The account name (e.g. "foo-manager")
# $3: The account display-name (e.g. "Manages all foo")
function ensure_service_account() {
if [ $# != 3 -o -z "$1" -o -z "$2" -o -x "$3" ]; then
if [ $# != 3 -o -z "$1" -o -z "$2" -o -z "$3" ]; then
echo "ensure_service_account(project, name, display_name) requires 3 arguments" >&2
return 1
fi
Expand All @@ -440,7 +440,7 @@ function ensure_service_account() {
# $2 The managed zone name (e.g. kubernetes-io)
# $3 The DNS zone name (e.g. kubernetes.io)
function ensure_dns_zone() {
if [ $# != 3 -o -z "$1" -o -z "$2" -o -x "$3" ]; then
if [ $# != 3 -o -z "$1" -o -z "$2" -o -z "$3" ]; then
echo "ensure_dns_zone(project, zone_name, dns_name) requires 3 arguments" >&2
return 1
fi
Expand Down

0 comments on commit 935c758

Please sign in to comment.