-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added files for ginkgo version and testrunner-image-sha #9470
Conversation
@SaumyaBhushan: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @SaumyaBhushan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SaumyaBhushan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
/check-cla |
Suggestion (@longwuyuan @strongjz @SaumyaBhushan ) As we are getting more and more of this situation of required software/versions, we should have all of this probably on a yaml file or json file. With that, during the build we can use tools like jq/yq to fetch version, URL, checksum, etc as required @strongjz was working on something like that, probably we can align how this will look like (on Slack) and have a single place with all the required softwares instead of creating individual files for each stuff. |
Oh ! I got your point @longwuyuan . This makes sense. let me work on that. |
Oops, @rikatz @strongjz @SaumyaBhushan @tao12345666333, Saw Ricardo's comments just now. Sorry. I agree that we should have one file as per Ricardo's comment. Waiting to see messages on ingress-nginx-dev channel in slack |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
added files for ginkgo version and testrunner-image-sha
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook