-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry static linking #9286
Conversation
Hi @esigo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test /triage accepted |
/lgtm |
/hold |
Just a question before merging, will this work with our current v1.21 version? How can we keep this in sync? Otherwise feel free to unhold :) |
@rikatz I dropped 1.21 from the supported table and removed it from e2e since 1.21 was EOL last month. |
Sorry nginx v1.21, not k8s |
@rikatz thanks. 1.21 should work with my last commit. I'll test tomorrow. |
@rikatz tested with nginx 1.21: |
Pardon my ignorance, but this errors in the end of the log are something concerning? |
Here I was able to load the module and the errors mean the collector/backend is not reachable. So I could produce traces but I send them to an address that does not exist and hence the errors. #9062 should be merged in order to configure the collector correctly. |
Thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: esigo, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* static otel lib * clean * nginx 1.21
What this PR does / why we need it:
This PR statically links OpenTelemetry dependencies to reduce the number and the size of the files stored in the side-car container.
The size of container image is reduced from ~50 to ~17 MB.
Types of changes
Which issue/s this PR fixes
related to #9016
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook