Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple tls hosts sharing the same secretName #88

Merged
merged 1 commit into from
Dec 26, 2016

Conversation

gianrubio
Copy link
Contributor

The new controller changed the way that lookup for a ssl certificate. On the current ingress, on contrib, this tls mapping below works, but when I moved for this repo, some tls aren't generated.

    tls:
    - hosts:
      - aaaa.fake-domain.me
      secretName: auth.fake-domain.me
    - hosts:
      - nnnn.fake-domain.me
      secretName: cauth.fake-domain.me
    - hosts:
      - gggg.fake-domain.me
      secretName: gate.fake-domain.me
    - hosts:
      - my.fake-domain.me
      secretName: my.fake-domain.me
    - hosts:
      - rrrr.fake-domain.me
      - ppp.fake-domain.me
      - jjjj.fake-domain.me
      secretName: eu-fake-domain.me

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 25, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 39.837% when pulling e033772 on gianrubio:fix-mutiple-tls into 3980756 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Dec 26, 2016

/lgtm

@k8s-ci-robot
Copy link
Contributor

@aledbf: you can't LGTM a PR unless you are assigned as a reviewer.

In response to this comment:

/lgtm

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf self-assigned this Dec 26, 2016
@aledbf
Copy link
Member

aledbf commented Dec 26, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2016
@aledbf aledbf merged commit c38868b into kubernetes:master Dec 26, 2016
@gianrubio gianrubio deleted the fix-mutiple-tls branch February 22, 2017 21:49
hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants