-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentelemetry module build #8585
Conversation
@esigo: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @esigo! |
Hi @esigo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Much much gratitude for this @esigo . Helps this project a lot |
/assign Looks good to me, @longwuyuan wdyt? If tested and works fine we can approve it :D |
@rikatz :-) this is 100% good to merge. FYI, there is history here. I created a issue in the Opentelemetry project open-telemetry/opentelemetry-cpp-contrib#141 and @esigo is a maintainer at OT is actually going above and beyond to help solve the confusing problem we are having with running OT module in sidecar. Thanks tons @esigo |
@longwuyuan I'm a big fan of K8s projects, happy to help :) |
/lgtm Thank you both for this :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: esigo, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@esigo You're great. If images works normally in the VM, can you push your docker image to the hub and provide it to me for download and test? thank |
It seems I have used the wrong sha256 in this PR. I have to raise another one to fix the hash. |
* nginx opentelemetry modules * revert sha check
What this PR does / why we need it:
This PR Fixes #8437 by installing gRPC and OpenTelemetry-cpp using a pattern similar to open-telemetry/opentelemetry-cpp#1382
The final image size is 48.9MB.
Types of changes
Which issue/s this PR fixes
fixes #8437
How Has This Been Tested?
Checklist: