Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new helm chart with certgen fixed #7478

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Release new helm chart with certgen fixed #7478

merged 2 commits into from
Aug 12, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Aug 10, 2021

What this PR does / why we need it:

Release new Chart pointing to the webhook certgen inside k8s repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

Fixes: #7418, #7448

How Has This Been Tested?

helm install -n ingress-nginx --set controller.admissionWebhooks.patch.image.repository="gcr.io/k8s-staging-ingress-nginx/kube-webhook-certgen" --set controller.admissionWebhooks.patch.image.tag="v20210810-helm-chart-3.35.0-27-g402f21bcb@sha256:f3b6b39a6062328c095337b4cadcefd1612348fdd5190b1dcbcb9b9e90bd8068" --devel --debug  ingress-nginx ingress-nginx/ingress-nginx

/hold
Please just lgtm/merge as kubernetes/k8s.io#2509 gets merged

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Aug 10, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Aug 10, 2021

/kind bug
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
tao12345666333
tao12345666333 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 10, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Aug 11, 2021

Did a dumb commit to trigger Kubernetes tests as well, please do not merge :)

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Aug 11, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2021
longwuyuan
longwuyuan reviewed Aug 12, 2021
View reviewed changes
charts/ingress-nginx/Chart.yaml Outdated
@@ -2,8 +2,8 @@ apiVersion: v2
name: ingress-nginx
# When the version is modified, make sure the artifacthub.io/changes list is updated
# Also update CHANGELOG.md
version: 4.0.0
appVersion: 1.0.0-beta.1
version: 4.0.0-beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current release in development is ;

% helm search repo ingress --devel
NAME                            CHART VERSION   APP VERSION     DESCRIPTION                                                                                                                                
ingress-nginx/ingress-nginx     4.0.0-beta.1    1.0.0-beta.1    Ingress controller for Kubernetes using NGINX a...

So maybe ;

version: 4.0.0-beta.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeah you are right. Fixing!

@longwuyuan
Copy link
Contributor

values.yaml does not have tag for the certgen image but that is not a stopper yet and can be fixed in a follow up PR

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@longwuyuan
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit f973f3f into kubernetes:dev-v1 Aug 12, 2021
@strongjz strongjz mentioned this pull request Aug 13, 2021
Merged
8 tasks
rikatz added a commit to rikatz/ingress-nginx that referenced this pull request Aug 21, 2021
@rikatz
Release new helm chart with certgen fixed (kubernetes#7478)
eef9ad2 
* Update go version, modules and remove ioutil

* Release new helm chart with certgen fixed
k8s-ci-robot pushed a commit that referenced this pull request Aug 21, 2021
@rikatz @tianhaopx
@rctay @cassid4 @tao12345666333 @kutysam @nanorobocop @Matt1360 @cpanato @kundan2707 @kd7lxl @toredash @boukeversteegh @shahidhs-ibm @strongjz @longwuyuan @nehaLohia27 @akshitgrover
Release v1 (#7470)
90c7968 
* Drop v1beta1 from ingress nginx (#7156)

* Drop v1beta1 from ingress nginx

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix intorstr logic in controller

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* fixing admission

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* more intorstr fixing

* correct template rendering

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix e2e tests for v1 api

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix gofmt errors

* This is finally working...almost there...

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Re-add removed validation of AdmissionReview

* Prepare for v1.0.0-alpha.1 release

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Update changelog and matrix table for v1.0.0-alpha.1 (#7274)

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* add docs for syslog feature (#7219)

* Fix link to e2e-tests.md in developer-guide (#7201)

* Use ENV expansion for namespace in args (#7146)

Update the DaemonSet namespace references to use the `POD_NAMESPACE` environment variable in the same way that the Deployment does.

* chart: using Helm builtin capabilities check (#7190)

Signed-off-by: Jintao Zhang <[email protected]>

* Update proper default value for HTTP2MaxConcurrentStreams in Docs (#6944)

It should be 128 as documented in https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/config/config.go#L780

* Fix MaxWorkerOpenFiles calculation on high cores nodes (#7107)

* Fix MaxWorkerOpenFiles calculation on high cores nodes

* Add e2e test for rlimit_nofile

* Fix doc for max-worker-open-files

* ingress/tcp: add additional error logging on failed (#7208)

* Add file containing stable release (#7313)

* Handle named (non-numeric) ports correctly (#7311)

Signed-off-by: Carlos Panato <[email protected]>

* Updated v1beta1 to v1 as its deprecated (#7308)

* remove mercurial from build (#7031)

* Retry to download maxmind DB if it fails (#7242)

* Retry to download maxmind DB if it fails.

Signed-off-by: Sergey Shakuto <[email protected]>

* Add retries count arg, move retry logic into DownloadGeoLite2DB function

Signed-off-by: Sergey Shakuto <[email protected]>

* Reorder parameters in DownloadGeoLite2DB

Signed-off-by: Sergey Shakuto <[email protected]>

* Remove hardcoded value

Signed-off-by: Sergey Shakuto <[email protected]>

* Release v1.0.0-alpha.1

* Add changelog for v1.0.0-alpha.2

* controller: ignore non-service backends (#7332)

* controller: ignore non-service backends

Signed-off-by: Carlos Panato <[email protected]>

* update per feedback

Signed-off-by: Carlos Panato <[email protected]>

* fix: allow scope/tcp/udp configmap namespace to altered (#7161)

* Lower webhook timeout for digital ocean (#7319)

* Lower webhook timeout for digital ocean

* Set Digital Ocean value controller.admissionWebhooks.timeoutSeconds to 29

* update OWNERS and aliases files (#7365) (#7366)

Signed-off-by: Carlos Panato <[email protected]>

* Downgrade Lua modules for s390x (#7355)

Downgrade Lua modules to last known working version.

* Fix IngressClass logic for newer releases (#7341)

* Fix IngressClass logic for newer releases

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Change e2e tests for the new IngressClass presence

* Fix chart and admission tests

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix helm chart test

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix reviews

* Remove ingressclass code from admission

* update tag to v1.0.0-beta.1

* update readme and changelog for v1.0.0-beta.1

* Release v1.0.0-beta.1 - helm and manifests (#7422)

* Change the order of annotation just to trigger a new helm release (#7425)

* [cherry-pick] Add dev-v1 branch into helm releaser (#7428)

* Add dev-v1 branch into helm releaser (#7424)

* chore: add link for artifacthub.io/prerelease annotations

Signed-off-by: Jintao Zhang <[email protected]>

Co-authored-by: Ricardo Katz <[email protected]>

* k8s job ci pipeline for dev-v1 br v1.22.0 (#7453)

* k8s job ci pipeline for dev-v1 br v1.22.0

Signed-off-by: Neha Lohia <[email protected]>

* k8s job ci pipeline for dev-v1 br v1.21.2

Signed-off-by: Neha Lohia <[email protected]>

* remove v1.21.1 version

Signed-off-by: Neha Lohia <[email protected]>

* Add controller.watchIngressWithoutClass config option (#7459)

Signed-off-by: Akshit Grover <[email protected]>

* Release new helm chart with certgen fixed (#7478)

* Update go version, modules and remove ioutil

* Release new helm chart with certgen fixed

* changed appversion, chartversion, TAG, image (#7490)

* Fix CI conflict

* Fix CI conflict

* Fix build.sh from rebase process

* Fix controller_test post rebase

Co-authored-by: Tianhao Guo <[email protected]>
Co-authored-by: Ray <[email protected]>
Co-authored-by: Bill Cassidy <[email protected]>
Co-authored-by: Jintao Zhang <[email protected]>
Co-authored-by: Sathish Ramani <[email protected]>
Co-authored-by: Mansur Marvanov <[email protected]>
Co-authored-by: Matt1360 <[email protected]>
Co-authored-by: Carlos Tadeu Panato Junior <[email protected]>
Co-authored-by: Kundan Kumar <[email protected]>
Co-authored-by: Tom Hayward <[email protected]>
Co-authored-by: Sergey Shakuto <[email protected]>
Co-authored-by: Tore <[email protected]>
Co-authored-by: Bouke Versteegh <[email protected]>
Co-authored-by: Shahid <[email protected]>
Co-authored-by: James Strong <[email protected]>
Co-authored-by: Long Wu Yuan <[email protected]>
Co-authored-by: Jintao Zhang <[email protected]>
Co-authored-by: Neha Lohia <[email protected]>
Co-authored-by: Akshit Grover <[email protected]>
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@rikatz @tianhaopx
@rctay @cassid4 @tao12345666333 @kutysam @nanorobocop @Matt1360 @cpanato @kundan2707 @kd7lxl @toredash @boukeversteegh @shahidhs-ibm @strongjz @longwuyuan @nehaLohia27 @akshitgrover @rchshld
Release v1 (kubernetes#7470)
4bf30ec 
* Drop v1beta1 from ingress nginx (kubernetes#7156)

* Drop v1beta1 from ingress nginx

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix intorstr logic in controller

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* fixing admission

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* more intorstr fixing

* correct template rendering

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix e2e tests for v1 api

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix gofmt errors

* This is finally working...almost there...

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Re-add removed validation of AdmissionReview

* Prepare for v1.0.0-alpha.1 release

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Update changelog and matrix table for v1.0.0-alpha.1 (kubernetes#7274)

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* add docs for syslog feature (kubernetes#7219)

* Fix link to e2e-tests.md in developer-guide (kubernetes#7201)

* Use ENV expansion for namespace in args (kubernetes#7146)

Update the DaemonSet namespace references to use the `POD_NAMESPACE` environment variable in the same way that the Deployment does.

* chart: using Helm builtin capabilities check (kubernetes#7190)

Signed-off-by: Jintao Zhang <[email protected]>

* Update proper default value for HTTP2MaxConcurrentStreams in Docs (kubernetes#6944)

It should be 128 as documented in https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/config/config.go#L780

* Fix MaxWorkerOpenFiles calculation on high cores nodes (kubernetes#7107)

* Fix MaxWorkerOpenFiles calculation on high cores nodes

* Add e2e test for rlimit_nofile

* Fix doc for max-worker-open-files

* ingress/tcp: add additional error logging on failed (kubernetes#7208)

* Add file containing stable release (kubernetes#7313)

* Handle named (non-numeric) ports correctly (kubernetes#7311)

Signed-off-by: Carlos Panato <[email protected]>

* Updated v1beta1 to v1 as its deprecated (kubernetes#7308)

* remove mercurial from build (kubernetes#7031)

* Retry to download maxmind DB if it fails (kubernetes#7242)

* Retry to download maxmind DB if it fails.

Signed-off-by: Sergey Shakuto <[email protected]>

* Add retries count arg, move retry logic into DownloadGeoLite2DB function

Signed-off-by: Sergey Shakuto <[email protected]>

* Reorder parameters in DownloadGeoLite2DB

Signed-off-by: Sergey Shakuto <[email protected]>

* Remove hardcoded value

Signed-off-by: Sergey Shakuto <[email protected]>

* Release v1.0.0-alpha.1

* Add changelog for v1.0.0-alpha.2

* controller: ignore non-service backends (kubernetes#7332)

* controller: ignore non-service backends

Signed-off-by: Carlos Panato <[email protected]>

* update per feedback

Signed-off-by: Carlos Panato <[email protected]>

* fix: allow scope/tcp/udp configmap namespace to altered (kubernetes#7161)

* Lower webhook timeout for digital ocean (kubernetes#7319)

* Lower webhook timeout for digital ocean

* Set Digital Ocean value controller.admissionWebhooks.timeoutSeconds to 29

* update OWNERS and aliases files (kubernetes#7365) (kubernetes#7366)

Signed-off-by: Carlos Panato <[email protected]>

* Downgrade Lua modules for s390x (kubernetes#7355)

Downgrade Lua modules to last known working version.

* Fix IngressClass logic for newer releases (kubernetes#7341)

* Fix IngressClass logic for newer releases

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Change e2e tests for the new IngressClass presence

* Fix chart and admission tests

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix helm chart test

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

* Fix reviews

* Remove ingressclass code from admission

* update tag to v1.0.0-beta.1

* update readme and changelog for v1.0.0-beta.1

* Release v1.0.0-beta.1 - helm and manifests (kubernetes#7422)

* Change the order of annotation just to trigger a new helm release (kubernetes#7425)

* [cherry-pick] Add dev-v1 branch into helm releaser (kubernetes#7428)

* Add dev-v1 branch into helm releaser (kubernetes#7424)

* chore: add link for artifacthub.io/prerelease annotations

Signed-off-by: Jintao Zhang <[email protected]>

Co-authored-by: Ricardo Katz <[email protected]>

* k8s job ci pipeline for dev-v1 br v1.22.0 (kubernetes#7453)

* k8s job ci pipeline for dev-v1 br v1.22.0

Signed-off-by: Neha Lohia <[email protected]>

* k8s job ci pipeline for dev-v1 br v1.21.2

Signed-off-by: Neha Lohia <[email protected]>

* remove v1.21.1 version

Signed-off-by: Neha Lohia <[email protected]>

* Add controller.watchIngressWithoutClass config option (kubernetes#7459)

Signed-off-by: Akshit Grover <[email protected]>

* Release new helm chart with certgen fixed (kubernetes#7478)

* Update go version, modules and remove ioutil

* Release new helm chart with certgen fixed

* changed appversion, chartversion, TAG, image (kubernetes#7490)

* Fix CI conflict

* Fix CI conflict

* Fix build.sh from rebase process

* Fix controller_test post rebase

Co-authored-by: Tianhao Guo <[email protected]>
Co-authored-by: Ray <[email protected]>
Co-authored-by: Bill Cassidy <[email protected]>
Co-authored-by: Jintao Zhang <[email protected]>
Co-authored-by: Sathish Ramani <[email protected]>
Co-authored-by: Mansur Marvanov <[email protected]>
Co-authored-by: Matt1360 <[email protected]>
Co-authored-by: Carlos Tadeu Panato Junior <[email protected]>
Co-authored-by: Kundan Kumar <[email protected]>
Co-authored-by: Tom Hayward <[email protected]>
Co-authored-by: Sergey Shakuto <[email protected]>
Co-authored-by: Tore <[email protected]>
Co-authored-by: Bouke Versteegh <[email protected]>
Co-authored-by: Shahid <[email protected]>
Co-authored-by: James Strong <[email protected]>
Co-authored-by: Long Wu Yuan <[email protected]>
Co-authored-by: Jintao Zhang <[email protected]>
Co-authored-by: Neha Lohia <[email protected]>
Co-authored-by: Akshit Grover <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longwuyuan longwuyuan longwuyuan left review comments

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@tao12345666333 tao12345666333

@longwuyuan longwuyuan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikatz @longwuyuan @k8s-ci-robot @tao12345666333