Chart template fix

[kevwil]

This fixes a few broken variable references in the helm chart.

What this PR does / why we need it:

When enabling autoscaling for the default backend, the template throws an error. This fixes that.

helm.go:81: [debug] template: ingress-nginx/templates/default-backend-hpa.yaml:8:20: executing "ingress-nginx/templates/default-backend-hpa.yaml" at <{{template "nginx-ingress.defaultBackend.fullname" .}}>: template "nginx-ingress.defaultBackend.fullname" not defined

Fixing that revealed a second error, which has also been fixed.

Error: template: ingress-nginx/templates/default-backend-hpa.yaml:11:28: executing "ingress-nginx/templates/default-backend-hpa.yaml" at <{{template "deployment.apiVersion" .}}>: template "deployment.apiVersion" not defined

Types of changes

• [X ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Using Helm 3.4.1:

helm template foo ./charts/ingress-nginx -f ./testvalues.yaml

where the testvalues.yaml file is the following:

controller:
  ingressClass: nginx-default
  service:
    omitClusterIP: true
    annotations:
      service.beta.kubernetes.io/aws-load-balancer-internal: "true"
      service.beta.kubernetes.io/aws-load-balancer-backend-protocol: tcp
      service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "3600"
  metrics:
    enabled: true
    service:
      omitClusterIP: true
  extraArgs:
    v: 5
  config:
    load-balance: ewma
  autoscaling:
    enabled: true
podSecurityPolicy:
  enabled: true
defaultBackend:
  enabled: true
  service:
    omitClusterIP: true
  autoscaling:
    enabled: true

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

My changes do not involve any app code, only the helm chart. No documentation change seems necessary and testing as described above is passing for me.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @kevwil!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kevwil. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevwil
To complete the pull request process, please assign chiefalexander after the PR has been reviewed.
You can assign the PR to them by writing /assign @chiefalexander in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kevwil]

I signed it

[aledbf]

Closing. Duplicate #6544