Add Default backend HPA autoscaling. #6423

haad · 2020-11-04T13:10:26Z

What this PR does / why we need it:

This PR will add conditional HPA for default backend for those who need to scale it. This change is already present at original HELM charts repository.

Types of changes

Bug fix (non-breaking change which fixes an issue)
[ X] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] My change requires a change to the documentation.
[x ] I have updated the documentation accordingly.
[x ] I've read the CONTRIBUTION guide
I have added tests to cover my changes.
All new and existing tests passed.

k8s-ci-robot · 2020-11-04T13:10:34Z

Welcome @haad!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-11-04T13:10:34Z

Hi @haad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ChiefAlexander · 2020-11-04T15:30:52Z

/ok-to-test

ChiefAlexander · 2020-11-04T15:31:25Z

charts/ingress-nginx/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 name: ingress-nginx
-version: 3.8.0
+version: 3.8.1


As this is a new feature please bump the minor version:

Suggested change

version: 3.8.1

version: 3.9.0

aledbf · 2020-11-04T15:51:32Z

@haad also, please update https://github.com/kubernetes/ingress-nginx/blob/master/charts/ingress-nginx/CHANGELOG.md
and cleanup https://github.com/kubernetes/ingress-nginx/blob/master/charts/ingress-nginx/Chart.yaml#L19, adding the title of the PR

aledbf · 2020-11-04T15:53:36Z

charts/ingress-nginx/README.md

@@ -219,3 +219,46 @@ Error: UPGRADE FAILED: Service "?????-controller" is invalid: spec.clusterIP: In
 Detail of how and why are in [this issue](https://github.com/helm/charts/pull/13646) but to resolve this you can set `xxxx.service.omitClusterIP` to `true` where `xxxx` is the service referenced in the error.

 As of version `1.26.0` of this chart, by simply not providing any clusterIP value, `invalid: spec.clusterIP: Invalid value: "": field is immutable` will no longer occur since `clusterIP: ""` will not be rendered.
+
+## Using custom default backend


Please don't add this information here. If you want to add another example, please open a different PR updating https://kubernetes.github.io/ingress-nginx/user-guide/default-backend/

Fixed, I think I will drop that for now.

aledbf · 2020-11-06T11:21:15Z

charts/ingress-nginx/Chart.yaml

@@ -16,6 +16,7 @@ engine: gotpl
 kubeVersion: ">=1.16.0-0"
 annotations:
  artifacthub.io/changes: |
+    - Add Default backend HPA autoscaling
    - Update jettech/kube-webhook-certgen image


Please remove the other items on the list. Only your change should be there.

For context, this is used to render the changelog in the artifacthub page like this

aledbf · 2020-11-06T13:21:49Z

/assign @ChiefAlexander

ChiefAlexander · 2020-11-06T17:43:23Z

charts/ingress-nginx/templates/default-backend-hpa.yaml

+  labels:
+    app: {{ template "nginx-ingress.name" . }}
+    chart: {{ template "nginx-ingress.chart" . }}
+    component: "{{ .Values.defaultBackend.name }}"
+    heritage: {{ .Release.Service }}
+    release: {{ .Release.Name }}


these labels are wrong for this chart

Suggested change

labels:

app: {{ template "nginx-ingress.name" . }}

chart: {{ template "nginx-ingress.chart" . }}

component: "{{ .Values.defaultBackend.name }}"

heritage: {{ .Release.Service }}

release: {{ .Release.Name }}

labels:

{{- include "ingress-nginx.labels" . | nindent 4 }}

app.kubernetes.io/component: default-backend

This is fixed now

ChiefAlexander · 2020-11-09T14:47:45Z

/lgtm

ChiefAlexander · 2020-11-09T14:47:52Z

Thanks for the PR!

k8s-ci-robot · 2020-11-09T14:48:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, haad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~charts/ingress-nginx/OWNERS~~ [ChiefAlexander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2020

k8s-ci-robot requested review from ChiefAlexander and cmluciano November 4, 2020 13:10

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2020

ChiefAlexander reviewed Nov 4, 2020

View reviewed changes

aledbf reviewed Nov 4, 2020

View reviewed changes

haad force-pushed the default-backend-autoscaling branch from d44a865 to cc53e2d Compare November 5, 2020 08:49

aledbf reviewed Nov 6, 2020

View reviewed changes

haad force-pushed the default-backend-autoscaling branch from 47db847 to 6f38b26 Compare November 6, 2020 12:55

k8s-ci-robot assigned ChiefAlexander Nov 6, 2020

ChiefAlexander suggested changes Nov 6, 2020

View reviewed changes

Add Default backend HPA autoscaling.

ab9ba3e

haad force-pushed the default-backend-autoscaling branch from 6f38b26 to ab9ba3e Compare November 6, 2020 18:37

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020

k8s-ci-robot merged commit 52726ab into kubernetes:master Nov 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Default backend HPA autoscaling. #6423

Add Default backend HPA autoscaling. #6423

haad commented Nov 4, 2020

k8s-ci-robot commented Nov 4, 2020

k8s-ci-robot commented Nov 4, 2020

ChiefAlexander commented Nov 4, 2020

ChiefAlexander Nov 4, 2020

haad Nov 6, 2020

aledbf commented Nov 4, 2020

aledbf Nov 4, 2020

haad Nov 6, 2020

aledbf Nov 6, 2020

haad Nov 6, 2020

aledbf commented Nov 6, 2020

ChiefAlexander Nov 6, 2020

haad Nov 7, 2020

ChiefAlexander commented Nov 9, 2020

ChiefAlexander commented Nov 9, 2020

k8s-ci-robot commented Nov 9, 2020

Add Default backend HPA autoscaling. #6423

Add Default backend HPA autoscaling. #6423

Conversation

haad commented Nov 4, 2020

What this PR does / why we need it:

Types of changes

Checklist:

k8s-ci-robot commented Nov 4, 2020

k8s-ci-robot commented Nov 4, 2020

ChiefAlexander commented Nov 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aledbf commented Nov 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aledbf commented Nov 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChiefAlexander commented Nov 9, 2020

ChiefAlexander commented Nov 9, 2020

k8s-ci-robot commented Nov 9, 2020