Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries for dns in tcp e2e test #5283

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Add retries for dns in tcp e2e test #5283

merged 1 commit into from
Mar 23, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 23, 2020

What this PR does / why we need it:

Fixes random e2e failures like
https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-ingress-nginx-e2e/1242099773025030144

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@codecov-io
Copy link

Codecov Report

Merging #5283 into master will increase coverage by 0.03%.
The diff coverage is 67.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5283      +/-   ##
==========================================
+ Coverage   58.58%   58.61%   +0.03%     
==========================================
  Files          88       88              
  Lines        6879     6901      +22     
==========================================
+ Hits         4030     4045      +15     
- Misses       2407     2412       +5     
- Partials      442      444       +2     
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 49.40% <ø> (ø)
internal/ingress/annotations/modsecurity/main.go 61.11% <50.00%> (-1.39%) ⬇️
internal/ingress/annotations/rewrite/main.go 50.00% <57.14%> (+1.61%) ⬆️
cmd/nginx/flags.go 83.08% <66.66%> (+0.76%) ⬆️
internal/ingress/controller/template/template.go 80.10% <75.00%> (+0.02%) ⬆️
internal/ingress/controller/nginx.go 29.72% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf7018...2b7ca2b. Read the comment docs.

@aledbf aledbf merged commit 760f40e into kubernetes:master Mar 23, 2020
@aledbf aledbf deleted the e2e branch March 23, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants