Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotations to location of default backend (root context) #527

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Add annotations to location of default backend (root context) #527

merged 1 commit into from
Apr 1, 2017

Conversation

jcmoraisjr
Copy link
Contributor

Fixes reading of ingress.kubernetes.io/app-root annotation from root context (default backend)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.825% when pulling 8552351 on jcmoraisjr:jm-ann-root-context into 8fc75dc on kubernetes:master.

@aledbf aledbf self-assigned this Apr 1, 2017
@aledbf
Copy link
Member

aledbf commented Apr 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2017
@aledbf
Copy link
Member

aledbf commented Apr 1, 2017

@jcmoraisjr thanks!

@aledbf aledbf merged commit 638ea2b into kubernetes:master Apr 1, 2017
@jcmoraisjr jcmoraisjr deleted the jm-ann-root-context branch April 1, 2017 18:00
@gianrubio gianrubio mentioned this pull request Apr 6, 2017
Merged
@jcmoraisjr jcmoraisjr mentioned this pull request Apr 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcmoraisjr @k8s-reviewable @coveralls @aledbf @k8s-ci-robot