-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not require go for building #5268
do not require go for building #5268
Conversation
This will fail. Please check https://github.com/kubernetes/ingress-nginx/blob/master/Makefile#L62 |
@aledbf that's fine, the caller can set ARCH to avoid it. |
Agree. That said, sorry but no. The change in this PR should include a change throw an error in that case. I added the validation because of a complaint about errors building for arm, without go installed (the image was generated for amd64) |
@aledbf I pushed a change for that. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Rel #5216
Given
USE_DOCKER
istrue
by default in the Makefile we should not require Go by default on the host machine.Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: