Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not require go for building #5268

Merged
merged 2 commits into from
Mar 19, 2020
Merged

do not require go for building #5268

merged 2 commits into from
Mar 19, 2020

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Rel #5216

Given USE_DOCKER is true by default in the Makefile we should not require Go by default on the host machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2020
@aledbf
Copy link
Member

aledbf commented Mar 19, 2020

This will fail. Please check https://github.com/kubernetes/ingress-nginx/blob/master/Makefile#L62
(commands before the tasks)

@ElvinEfendi
Copy link
Member Author

ElvinEfendi commented Mar 19, 2020

@aledbf that's fine, the caller can set ARCH to avoid it.

@aledbf
Copy link
Member

aledbf commented Mar 19, 2020

that's fine, the caller can set ARCH to avoid it.

Agree. That said, sorry but no. The change in this PR should include a change throw an error in that case. I added the validation because of a complaint about errors building for arm, without go installed (the image was generated for amd64)

@ElvinEfendi
Copy link
Member Author

@aledbf I pushed a change for that.

@aledbf
Copy link
Member

aledbf commented Mar 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 906e501 into kubernetes:master Mar 19, 2020
@ElvinEfendi ElvinEfendi deleted the do-not-require-go branch March 19, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants