-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy_ssl_name support #5166
proxy_ssl_name support #5166
Conversation
Hi @janosi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5166 +/- ##
=========================================
Coverage ? 58.61%
=========================================
Files ? 88
Lines ? 6872
Branches ? 0
=========================================
Hits ? 4028
Misses ? 2402
Partials ? 442
Continue to review full report at Codecov.
|
/retest |
/lgtm |
@janosi thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, janosi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
It implements the support of
proxy_ssl_name
on server and location levels.Credit goes to the original PR #4639 , this is only a continuation of that, with the additional location level support requested in that PR.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Unit test
Checklist: