Added configmap test for ssl-ciphers.

[SzekeresB]

What this PR does / why we need it:

Adds configmap test for ssl-ciphers.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

None

How Has This Been Tested?

make FOCUS="Configmap - ssl-ciphers" kind-e2e-test

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @SzekeresB. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aledbf]

@SzekeresB this can be simpler

var _ = framework.DescribeSetting("ssl-ciphers", func() {
	f := framework.NewDefaultFramework("ssl-ciphers")

	ginkgo.It("Add ssl ciphers", func() {
		wlKey := "ssl-ciphers"
		wlValue := "ALL:!aNULL:!EXPORT56:RC4+RSA:+HIGH:+MEDIUM:+LOW:+SSLv2:+EXP"

		f.UpdateNginxConfigMapData(wlKey, wlValue)

		f.WaitForNginxConfiguration(func(cfg string) bool {
			return strings.Contains(cfg, fmt.Sprintf("ssl_ciphers '%s';", wlValue))
		})
	})
})

• DescribeSetting: adds [Setting] in the output of the tests. No need for Configmap, is implicit.
• This tests a change in the global configuration, no need to create an ingress

[aledbf]

/ok-to-test

[SzekeresB]

@aledbf I see, thank you! Changed for a simpler implementation, as you suggested.

[aledbf]

@SzekeresB for some context. The suggested change and one of the reasons behind the e2e refactor was related to the verification of deployments required in e2e tests to see if we were wasting resources and increasing the execution time of the suite.

[codecov-io]

Codecov Report

Merging #5140 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5140   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          88       88           
  Lines        6850     6850           
=======================================
  Hits         4018     4018           
  Misses       2391     2391           
  Partials      441      441

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a922d7d...0986ea8. Read the comment docs.

[aledbf]

/retest

[SzekeresB]

@aledbf Understood, I will try to pay attention to this in the future.

[aledbf]

/lgtm
/approve

[aledbf]

@SzekeresB thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, SzekeresB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment