-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configmap test for no-tls-redirect-locations #5103
Added configmap test for no-tls-redirect-locations #5103
Conversation
Hi @SzekeresB. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5103 +/- ##
==========================================
+ Coverage 58.65% 58.68% +0.02%
==========================================
Files 88 88
Lines 6850 6850
==========================================
+ Hits 4018 4020 +2
+ Misses 2391 2390 -1
+ Partials 441 440 -1
Continue to review full report at Codecov.
|
f.EnsureIngress(ing) | ||
|
||
f.WaitForNginxConfiguration(func(server string) bool { | ||
return strings.Contains(server, fmt.Sprintf("force_no_ssl_redirect = false,")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to !strings.Contains(server, fmt.Sprintf("force_no_ssl_redirect = true,"))
. The reason is because the server block contains two locations and WaitForNginxConfiguration includes both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I changed it.
/retest |
/lgtm |
@SzekeresB thanks! |
f5446b9
to
aa3980a
Compare
aa3980a
to
122bf02
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, SzekeresB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Added basic check for no-tls-redirect-locations configmap paramter.
Types of changes
Which issue/s this PR fixes
None
How Has This Been Tested?
make FOCUS="Add no tls redirect locations" kind-e2e-test
Checklist: