-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor how to handle sigterm and nginx process goroutine #4959
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
- Coverage 58.48% 58.45% -0.03%
==========================================
Files 88 88
Lines 6728 6728
==========================================
- Hits 3935 3933 -2
- Misses 2363 2364 +1
- Partials 430 431 +1
Continue to review full report at Codecov.
|
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: