Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker to run makefile tasks #4893

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 7, 2020

What this PR does / why we need it: documents makefile tasks, add a new help task and uses docker to run several tasks

make

Usage:
  make <target>
  help             Display this help
  all-container    Build image for amd64, arm and arm64.
  all-push         Publish images for amd64, arm and arm64.
  container        Build image for a particular arch.
  clean-container  Removes local image
  register-qemu    Register /usr/bin/qemu-ARCH-static as the handler for binaries in multiple platforms
  push             Publish image for a particular arch.
  build            Build ingress controller, debug tool and pre-stop hook.
  build-plugin     Build ingress-nginx krew plugin.
  clean            Remove .gocache directory.
  static-check     Run verification script for boilerplate, codegen, gofmt, golint and lualint.
  test             Run go unit tests.
  lua-test         Run lua unit tests.
  cover            Run go coverage unit tests.
  release          Build and publish images of the ingress controller.
  check_dead_links  Check if the documentation contains dead links.
  dep-ensure       Update and vendo go dependencies.
  dev-env          Starts a local Kubernetes cluster using minikube, building and deploying the ingress controller.
  live-docs        Build and launch a local copy of the documentation website in http://localhost:3000
  build-docs       Build documentation (output in ./site directory).
  misspell         Check for spelling errors.
  run-ingress-controller  Run the ingress controller locally using a kubectl proxy connection.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@aledbf
Copy link
Member Author

aledbf commented Jan 7, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2020
@aledbf aledbf force-pushed the makefile branch 2 times, most recently from 07bde14 to 1e69d9e Compare January 8, 2020 15:35
@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a8c2c9c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4893   +/-   ##
=========================================
  Coverage          ?   58.44%           
=========================================
  Files             ?       88           
  Lines             ?     6729           
  Branches          ?        0           
=========================================
  Hits              ?     3933           
  Misses            ?     2365           
  Partials          ?      431

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c2c9c...dc3c8e3. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jan 8, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jan 9, 2020

/test all

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jan 9, 2020

/test all

@aledbf aledbf merged commit fcd3a58 into kubernetes:master Jan 9, 2020
@aledbf aledbf deleted the makefile branch January 9, 2020 11:45
@aledbf aledbf mentioned this pull request Jan 9, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants