Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky session for ingress without host #4867

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 28, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3959 #4786

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2019
@codecov-io
Copy link

codecov-io commented Dec 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8db541e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4867   +/-   ##
=========================================
  Coverage          ?   58.48%           
=========================================
  Files             ?       88           
  Lines             ?     6716           
  Branches          ?        0           
=========================================
  Hits              ?     3928           
  Misses            ?     2359           
  Partials          ?      429
Impacted Files Coverage Δ
internal/ingress/zz_generated.deepcopy.go 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db541e...41a3e04. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

@ElvinEfendi
Copy link
Member

LGTM - just one redundant line.

@aledbf
Copy link
Member Author

aledbf commented Jan 2, 2020

/retest

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2020
@ElvinEfendi
Copy link
Member

/test pull-ingress-nginx-e2e-1-17

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member Author

aledbf commented Jan 2, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit f42f559 into kubernetes:master Jan 2, 2020
@aledbf aledbf deleted the sticky-fix branch January 3, 2020 01:24
@davidfowl
Copy link

@aledbf thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.21.0 breaks stickiness for default host
5 participants