-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sticky session for ingress without host #4867
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4867 +/- ##
=========================================
Coverage ? 58.48%
=========================================
Files ? 88
Lines ? 6716
Branches ? 0
=========================================
Hits ? 3928
Misses ? 2359
Partials ? 429
Continue to review full report at Codecov.
|
/retest |
1 similar comment
/retest |
LGTM - just one redundant line. |
/retest |
/lgtm |
/test pull-ingress-nginx-e2e-1-17 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@aledbf thanks! |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #3959 #4786Special notes for your reviewer: