Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom CA certificate when flag --api-server is specified #4807

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 2, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4783

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #4807 into master will decrease coverage by 0.07%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4807      +/-   ##
==========================================
- Coverage   58.59%   58.51%   -0.08%     
==========================================
  Files          88       88              
  Lines        6702     6714      +12     
==========================================
+ Hits         3927     3929       +2     
- Misses       2349     2359      +10     
  Partials      426      426
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 50.49% <ø> (ø) ⬆️
cmd/nginx/main.go 6.21% <11.11%> (-0.29%) ⬇️
cmd/nginx/flags.go 85.94% <60%> (-0.73%) ⬇️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9e2b2...dc4ab8d. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Dec 2, 2019

/retest

@aledbf aledbf merged commit 19d596b into kubernetes:master Dec 5, 2019
@aledbf aledbf deleted the ca branch December 5, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants