-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to quote expansion of $cfg.LogFormatStream
in log_stream
access log
#4658
Need to quote expansion of $cfg.LogFormatStream
in log_stream
access log
#4658
Conversation
format in nginx.tmpl otherwise individual variables are just glued together without separating spaces so that you would get these in access logs: [10/Oct/2019:05:03:30 +0000]TCP200000.003 [10/Oct/2019:05:03:30 +0000]TCP200000.000 [10/Oct/2019:05:05:04 +0000]TCP200000.000 which supposed to be someting like these: [10/Oct/2019:05:03:30 +0000] TCP 200 0 0 0.003 [10/Oct/2019:05:03:30 +0000] TCP 200 0 0 0.000 [10/Oct/2019:05:05:04 +0000] TCP 200 0 0 0.000
Welcome @turchanov! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @turchanov. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed the agreement. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, turchanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
+ Coverage 58.67% 58.72% +0.04%
==========================================
Files 88 88
Lines 6764 6766 +2
==========================================
+ Hits 3969 3973 +4
+ Misses 2356 2355 -1
+ Partials 439 438 -1
Continue to review full report at Codecov.
|
/retest |
format in
nginx.tmpl
otherwise individual variables are just glued togetherwithout separating spaces so that you would get these in access logs:
which supposed to be someting like these: