Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup unused certificates #4594

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented Sep 24, 2019

What this PR does / why we need it:

Currently when TLS section from an ingress is removed we don't cleanup corresponding certificate from Lua shared dict. This PR makes sure we clean them up. Notice that I'm still not cleaning the certificate itself and deleting only server. I can not delete certificate because relationship between certificates and servers is one to many.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1dc4d18). Click here to learn what that means.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4594   +/-   ##
=========================================
  Coverage          ?   58.58%           
=========================================
  Files             ?       88           
  Lines             ?     6735           
  Branches          ?        0           
=========================================
  Hits              ?     3946           
  Misses            ?     2352           
  Partials          ?      437
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 29.8% <64.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc4d18...e392c8a. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Sep 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73bc2cf into kubernetes:master Sep 24, 2019
@ElvinEfendi ElvinEfendi deleted the cleanup-certs branch September 24, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants