-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about SSL certificates in the default log level. #459
Conversation
Coverage remained the same at 43.266% when pulling b384a06bb467ad9db8f1c77ab5b07a8a0f0f018a on aledbf:log-ssl-information into c25936d on kubernetes:master. |
b384a06
to
6fee691
Compare
Coverage decreased (-0.003%) to 43.174% when pulling 6fee691df3a78d5af36eeb239ff570e485fda8ea on aledbf:log-ssl-information into a5f8fe2 on kubernetes:master. |
6fee691
to
18492c1
Compare
s, err = ssl.AddOrUpdateCertAndKey(nsSecName, cert, key, ca) | ||
} else if ca != nil { | ||
glog.V(3).Infof("found only ca.crt, configuring %v as an Certificate Authentication secret", secretName) | ||
glog.Infof("found only ca.crt, configuring %v as an Certificate Authentication secret", secretName) | ||
s, err = ssl.AddCertAuth(nsSecName, ca) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf these lines above log every 10 seconds. Don't know if the whole func shouldn't be running or if the logs shouldn't be as default logs. What about reinclude V()
until a correct fix is provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if the whole func shouldn't be running or if the logs shouldn't be as default logs
We need to know if there is an issue with the certs. Let me see if I can change this to show only errors in the default level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf Our logs are a bit noisy and I think there is nothing we can do outside Ingress core. Let me know if I can provide some help or if there is a fix in a couple of days. Otherwise no problem! I make a temporary fork and wait the final solution.
No description provided.