Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression test for the issue fixed in #4543 #4548

Merged
merged 1 commit into from
Sep 10, 2019
Merged

regression test for the issue fixed in #4543 #4548

merged 1 commit into from
Sep 10, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
This is to make sure the fix in #4543 is covered by test.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2019
@aledbf
Copy link
Member

aledbf commented Sep 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Sep 10, 2019

/retest

@codecov-io
Copy link

Codecov Report

Merging #4548 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4548      +/-   ##
==========================================
- Coverage   59.38%   59.35%   -0.03%     
==========================================
  Files          89       89              
  Lines        6823     6823              
==========================================
- Hits         4052     4050       -2     
- Misses       2335     2336       +1     
- Partials      436      437       +1
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 88.29% <0%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63dfa2b...bbcf3dc. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit fe4f178 into kubernetes:master Sep 10, 2019
@ElvinEfendi ElvinEfendi deleted the regression-test branch September 10, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants