-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove invalid log "Failed to executing diff command: exit status 1" #4416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4416 +/- ##
==========================================
- Coverage 58.64% 58.61% -0.04%
==========================================
Files 88 88
Lines 6572 6572
==========================================
- Hits 3854 3852 -2
- Misses 2288 2291 +3
+ Partials 430 429 -1
Continue to review full report at Codecov.
|
/test pull-ingress-nginx-e2e-1-15 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-ingress-nginx-e2e-1-15 |
/test pull-ingress-nginx-test |
1 similar comment
/test pull-ingress-nginx-test |
What this PR does / why we need it:
From http://man7.org/linux/man-pages/man1/diff.1.html Exit status is 0 if inputs are the same, 1 if different, 2 if trouble.
This is interpreted as "error" but this is true only when the exit code is 2