Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go dependencies #4322

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Update go dependencies #4322

merged 1 commit into from
Jul 17, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 15, 2019

What this PR does / why we need it:

Fix build error when go modules is enabled:

verifying k8s.io/[email protected]: checksum mismatch
        downloaded: h1:hCxpvNwTKkj9EFQLTuiPM1MTwrugAOM1d3vA0na7JQg=
        go.sum:     h1:7RlwIuEBw1gYSVZwuXjjpsfA04npKVo0ZHJH5wtYtMM=

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jul 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2019
@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2019

/test pull-ingress-nginx-test

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jul 15, 2019

/test pull-ingress-nginx-test

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@28cc3bb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4322   +/-   ##
=========================================
  Coverage          ?   58.33%           
=========================================
  Files             ?       87           
  Lines             ?     6478           
  Branches          ?        0           
=========================================
  Hits              ?     3779           
  Misses            ?     2273           
  Partials          ?      426

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cc3bb...362fd3b. Read the comment docs.

@dims
Copy link
Member

dims commented Jul 16, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims July 16, 2019 20:46
@aledbf aledbf merged commit a54ab33 into kubernetes:master Jul 17, 2019
@aledbf aledbf deleted the fix-build branch July 17, 2019 15:12
k8s.io/cloud-provider v0.0.0-20190323031113-9c9d72d1bf90 // indirect
k8s.io/code-generator v0.0.0
k8s.io/cli-runtime v0.0.0-20190711111425-61e036b70227
k8s.io/client-go v12.0.0+incompatible
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this version derived? It fails validation in Go 1.13: the +incompatible annotation is only supported for versions that lack a go.mod file, and the version of client-go tagged v12.0.0 does include such a file.

(See kubernetes/client-go#631 and golang/go#33558.)

Copy link
Member Author

@aledbf aledbf Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willb we are aware of this issue and will be fixed in the next update of the dependencies

How was this version derived?

From the examples in client go. If you check the required section we have a valid commit https://github.com/kubernetes/ingress-nginx/blob/master/go.mod#L72

It fails validation in Go 1.13:

Sure, but that is a change that a not released version go is introducing. Before 1.12.6 this was ok.

Please check #4386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants