-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go dependencies #4322
Update go dependencies #4322
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-ingress-nginx-test |
1 similar comment
/test pull-ingress-nginx-test |
Codecov Report
@@ Coverage Diff @@
## master #4322 +/- ##
=========================================
Coverage ? 58.33%
=========================================
Files ? 87
Lines ? 6478
Branches ? 0
=========================================
Hits ? 3779
Misses ? 2273
Partials ? 426 Continue to review full report at Codecov.
|
/uncc |
k8s.io/cloud-provider v0.0.0-20190323031113-9c9d72d1bf90 // indirect | ||
k8s.io/code-generator v0.0.0 | ||
k8s.io/cli-runtime v0.0.0-20190711111425-61e036b70227 | ||
k8s.io/client-go v12.0.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this version derived? It fails validation in Go 1.13: the +incompatible
annotation is only supported for versions that lack a go.mod
file, and the version of client-go
tagged v12.0.0
does include such a file.
(See kubernetes/client-go#631 and golang/go#33558.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willb we are aware of this issue and will be fixed in the next update of the dependencies
How was this version derived?
From the examples in client go. If you check the required section we have a valid commit https://github.com/kubernetes/ingress-nginx/blob/master/go.mod#L72
It fails validation in Go 1.13:
Sure, but that is a change that a not released version go is introducing. Before 1.12.6 this was ok.
Please check #4386
What this PR does / why we need it:
Fix build error when go modules is enabled:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: